diff options
author | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
---|---|---|
committer | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
commit | 0023fc78d056556b353ee17f03760bec8c1fee49 (patch) | |
tree | 009367358a1c44b08f3142f63b087d936206ba44 /cc/test/tiled_layer_test_common.h | |
parent | 37df32bd517577ac6ad20c6d76b236265caeacaf (diff) | |
download | chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.zip chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.gz chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.bz2 |
Pass gfx::Rect and gfx::RectF by const ref.
Avoid unneccessary copy of structures gfx::Rect & gfx::RectF
by passing them by const ref rather than value.
Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.
Pass by value creates unneccessary overhead which should be avoided.
BUG=159273
Review URL: https://codereview.chromium.org/93663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244224 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/test/tiled_layer_test_common.h')
-rw-r--r-- | cc/test/tiled_layer_test_common.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/cc/test/tiled_layer_test_common.h b/cc/test/tiled_layer_test_common.h index ea1eb12..17de629 100644 --- a/cc/test/tiled_layer_test_common.h +++ b/cc/test/tiled_layer_test_common.h @@ -29,7 +29,7 @@ class FakeLayerUpdater : public LayerUpdater { virtual ~Resource(); virtual void Update(ResourceUpdateQueue* queue, - gfx::Rect source_rect, + const gfx::Rect& source_rect, gfx::Vector2d dest_offset, bool partial_update) OVERRIDE; @@ -45,14 +45,14 @@ class FakeLayerUpdater : public LayerUpdater { virtual scoped_ptr<LayerUpdater::Resource> CreateResource( PrioritizedResourceManager* resource) OVERRIDE; - virtual void PrepareToUpdate(gfx::Rect content_rect, + virtual void PrepareToUpdate(const gfx::Rect& content_rect, gfx::Size tile_size, float contents_width_scale, float contents_height_scale, gfx::Rect* resulting_opaque_rect) OVERRIDE; // Sets the rect to invalidate during the next call to PrepareToUpdate(). // After the next call to PrepareToUpdate() the rect is reset. - void SetRectToInvalidate(gfx::Rect rect, FakeTiledLayer* layer); + void SetRectToInvalidate(const gfx::Rect& rect, FakeTiledLayer* layer); // Last rect passed to PrepareToUpdate(). gfx::Rect last_update_rect() const { return last_update_rect_; } @@ -65,7 +65,7 @@ class FakeLayerUpdater : public LayerUpdater { void ClearUpdateCount() { update_count_ = 0; } void Update() { update_count_++; } - void SetOpaquePaintRect(gfx::Rect opaque_paint_rect) { + void SetOpaquePaintRect(const gfx::Rect& opaque_paint_rect) { opaque_paint_rect_ = opaque_paint_rect; } |