diff options
author | mithro <mithro@mithis.com> | 2015-05-04 22:23:45 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-05-05 05:24:24 +0000 |
commit | 248d172e6a28652b0159dfc5c33425c7507f8034 (patch) | |
tree | ad28e1a6aa69a53cb8b2e433ceb564a9f77c5b74 /cc/trees | |
parent | 1f5d6196b8d53e70e7a7a2276cdf3481365e7e04 (diff) | |
download | chromium_src-248d172e6a28652b0159dfc5c33425c7507f8034.zip chromium_src-248d172e6a28652b0159dfc5c33425c7507f8034.tar.gz chromium_src-248d172e6a28652b0159dfc5c33425c7507f8034.tar.bz2 |
cc: Removing base::TimeTicks argument to DrawLayers as it isn't used.
R=skyostil,brianderson
BUG=346230
Review URL: https://codereview.chromium.org/340743002
Cr-Commit-Position: refs/heads/master@{#328283}
Diffstat (limited to 'cc/trees')
-rw-r--r-- | cc/trees/layer_tree_host_impl.cc | 5 | ||||
-rw-r--r-- | cc/trees/layer_tree_host_impl.h | 2 | ||||
-rw-r--r-- | cc/trees/layer_tree_host_impl_unittest.cc | 100 | ||||
-rw-r--r-- | cc/trees/single_thread_proxy.cc | 10 | ||||
-rw-r--r-- | cc/trees/single_thread_proxy.h | 3 | ||||
-rw-r--r-- | cc/trees/thread_proxy.cc | 3 |
6 files changed, 60 insertions, 63 deletions
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc index 2da9fe3..3d566ba 100644 --- a/cc/trees/layer_tree_host_impl.cc +++ b/cc/trees/layer_tree_host_impl.cc @@ -1483,9 +1483,10 @@ CompositorFrameMetadata LayerTreeHostImpl::MakeCompositorFrameMetadata() const { return metadata; } -void LayerTreeHostImpl::DrawLayers(FrameData* frame, - base::TimeTicks frame_begin_time) { +void LayerTreeHostImpl::DrawLayers(FrameData* frame) { TRACE_EVENT0("cc", "LayerTreeHostImpl::DrawLayers"); + + base::TimeTicks frame_begin_time = CurrentBeginFrameArgs().frame_time; DCHECK(CanDraw()); if (!frame->composite_events.empty()) { diff --git a/cc/trees/layer_tree_host_impl.h b/cc/trees/layer_tree_host_impl.h index 8f97704..720bbcd 100644 --- a/cc/trees/layer_tree_host_impl.h +++ b/cc/trees/layer_tree_host_impl.h @@ -232,7 +232,7 @@ class CC_EXPORT LayerTreeHostImpl // DidDrawAllLayers must also be called, regardless of whether DrawLayers is // called between the two. virtual DrawResult PrepareToDraw(FrameData* frame); - virtual void DrawLayers(FrameData* frame, base::TimeTicks frame_begin_time); + virtual void DrawLayers(FrameData* frame); // Must be called if and only if PrepareToDraw was called. void DidDrawAllLayers(const FrameData& frame); diff --git a/cc/trees/layer_tree_host_impl_unittest.cc b/cc/trees/layer_tree_host_impl_unittest.cc index d8af745f..ec519ee 100644 --- a/cc/trees/layer_tree_host_impl_unittest.cc +++ b/cc/trees/layer_tree_host_impl_unittest.cc @@ -325,7 +325,7 @@ class LayerTreeHostImplTest : public testing::Test, void DrawFrame() { LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); } @@ -2006,7 +2006,7 @@ TEST_F(LayerTreeHostImplTest, WillDrawReturningFalseDoesNotCall) { { LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); EXPECT_TRUE(layer->will_draw_called()); @@ -2023,7 +2023,7 @@ TEST_F(LayerTreeHostImplTest, WillDrawReturningFalseDoesNotCall) { layer->ClearDidDrawCheck(); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); EXPECT_TRUE(layer->will_draw_called()); @@ -2055,7 +2055,7 @@ TEST_F(LayerTreeHostImplTest, DidDrawNotCalledOnHiddenLayer) { EXPECT_FALSE(layer->did_draw_called()); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); EXPECT_FALSE(layer->will_draw_called()); @@ -2070,7 +2070,7 @@ TEST_F(LayerTreeHostImplTest, DidDrawNotCalledOnHiddenLayer) { EXPECT_FALSE(layer->did_draw_called()); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); EXPECT_TRUE(layer->will_draw_called()); @@ -2110,7 +2110,7 @@ TEST_F(LayerTreeHostImplTest, WillDrawNotCalledOnOccludedLayer) { EXPECT_FALSE(top_layer->did_draw_called()); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); EXPECT_FALSE(occluded_layer->will_draw_called()); @@ -2145,7 +2145,7 @@ TEST_F(LayerTreeHostImplTest, DidDrawCalledOnAllLayers) { FakeLayerTreeHostImpl::RecursiveUpdateNumChildren( host_impl_->active_tree()->root_layer()); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); EXPECT_TRUE(root->did_draw_called()); @@ -2295,7 +2295,7 @@ TEST_F(LayerTreeHostImplTest, PrepareToDrawSucceedsAndFails) { LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); host_impl_->SwapBuffers(frame); @@ -2343,7 +2343,7 @@ TEST_F(LayerTreeHostImplTest, PrepareToDrawSucceedsAndFails) { LayerTreeHostImpl::FrameData frame; EXPECT_EQ(testcase.expected_result, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); host_impl_->SwapBuffers(frame); } @@ -2382,7 +2382,7 @@ TEST_F(LayerTreeHostImplTest, LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); host_impl_->SwapBuffers(frame); @@ -2430,7 +2430,7 @@ TEST_F(LayerTreeHostImplTest, LayerTreeHostImpl::FrameData frame; EXPECT_EQ(testcase.expected_result, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); host_impl_->SwapBuffers(frame); } @@ -3391,7 +3391,7 @@ TEST_F(LayerTreeHostImplTest, PageScaleDeltaAppliedToRootScrollLayerOnly) { // the page scale delta on the root layer is applied hierarchically. LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); EXPECT_EQ(1.f, root->draw_transform().matrix().getDouble(0, 0)); @@ -4065,7 +4065,7 @@ TEST_F(LayerTreeHostImplTest, // Check scroll delta reflected in layer. LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); EXPECT_FALSE(frame.has_no_damage); CheckLayerScrollDelta(scroll_layer, ScrollOffsetToVector2dF(scroll_offset)); @@ -4524,7 +4524,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer1->SetExpectation(false, false); layer1->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4533,7 +4533,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer1->SetExpectation(true, false); layer1->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4543,7 +4543,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer1->SetExpectation(true, false); layer1->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4553,7 +4553,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer1->SetExpectation(true, false); layer1->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4575,7 +4575,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer2->SetExpectation(false, false); layer2->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); EXPECT_TRUE(layer2->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4588,7 +4588,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer2->SetExpectation(false, false); layer2->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); EXPECT_TRUE(layer2->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4602,7 +4602,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer2->SetExpectation(false, false); layer2->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); EXPECT_TRUE(layer2->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4622,7 +4622,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { FakeLayerTreeHostImpl::RecursiveUpdateNumChildren( host_impl_->active_tree()->root_layer()); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); EXPECT_TRUE(layer2->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4639,7 +4639,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer2->SetExpectation(true, false); layer2->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); EXPECT_TRUE(layer2->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4654,7 +4654,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer2->SetExpectation(true, false); layer2->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); EXPECT_TRUE(layer2->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4670,7 +4670,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer2->SetExpectation(false, false); layer2->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); EXPECT_TRUE(layer2->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4683,7 +4683,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer1->SetExpectation(true, false); layer1->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4695,7 +4695,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer1->SetExpectation(true, false); layer1->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4707,7 +4707,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer1->SetExpectation(true, false); layer1->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); host_impl_->DidDrawAllLayers(frame); @@ -4720,7 +4720,7 @@ TEST_F(LayerTreeHostImplTest, BlendingOffWhenDrawingOpaqueLayers) { layer1->SetExpectation(false, false); layer1->SetUpdateRect(gfx::Rect(layer1->content_bounds())); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(layer1->quads_appended()); host_impl_->DidDrawAllLayers(frame); } @@ -5000,7 +5000,7 @@ TEST_F(LayerTreeHostImplTest, ReshapeNotCalledUntilDraw) { host_impl_->SetViewportSize(gfx::Size(10, 10)); host_impl_->SetDeviceScaleFactor(1.f); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(provider->TestContext3d()->reshape_called()); EXPECT_EQ(provider->TestContext3d()->width(), 10); EXPECT_EQ(provider->TestContext3d()->height(), 10); @@ -5010,7 +5010,7 @@ TEST_F(LayerTreeHostImplTest, ReshapeNotCalledUntilDraw) { host_impl_->SetViewportSize(gfx::Size(20, 30)); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(provider->TestContext3d()->reshape_called()); EXPECT_EQ(provider->TestContext3d()->width(), 20); EXPECT_EQ(provider->TestContext3d()->height(), 30); @@ -5020,7 +5020,7 @@ TEST_F(LayerTreeHostImplTest, ReshapeNotCalledUntilDraw) { host_impl_->SetDeviceScaleFactor(2.f); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); EXPECT_TRUE(provider->TestContext3d()->reshape_called()); EXPECT_EQ(provider->TestContext3d()->width(), 20); EXPECT_EQ(provider->TestContext3d()->height(), 30); @@ -5071,7 +5071,7 @@ TEST_F(LayerTreeHostImplTest, PartialSwapReceivesDamageRect) { // First frame, the entire screen should get swapped. EXPECT_EQ(DRAW_SUCCESS, layer_tree_host_impl->PrepareToDraw(&frame)); - layer_tree_host_impl->DrawLayers(&frame, gfx::FrameTime::Now()); + layer_tree_host_impl->DrawLayers(&frame); layer_tree_host_impl->DidDrawAllLayers(frame); layer_tree_host_impl->SwapBuffers(frame); gfx::Rect expected_swap_rect(0, 0, 500, 500); @@ -5085,7 +5085,7 @@ TEST_F(LayerTreeHostImplTest, PartialSwapReceivesDamageRect) { layer_tree_host_impl->active_tree()->root_layer()->children()[0]->SetPosition( gfx::PointF()); EXPECT_EQ(DRAW_SUCCESS, layer_tree_host_impl->PrepareToDraw(&frame)); - layer_tree_host_impl->DrawLayers(&frame, gfx::FrameTime::Now()); + layer_tree_host_impl->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); layer_tree_host_impl->SwapBuffers(frame); @@ -5101,7 +5101,7 @@ TEST_F(LayerTreeHostImplTest, PartialSwapReceivesDamageRect) { layer_tree_host_impl->active_tree()->root_layer()->SetBackgroundColor( SK_ColorBLACK); EXPECT_EQ(DRAW_SUCCESS, layer_tree_host_impl->PrepareToDraw(&frame)); - layer_tree_host_impl->DrawLayers(&frame, gfx::FrameTime::Now()); + layer_tree_host_impl->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); layer_tree_host_impl->SwapBuffers(frame); @@ -5265,7 +5265,7 @@ TEST_F(LayerTreeHostImplTest, NoPartialSwap) { { LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); } Mock::VerifyAndClearExpectations(&mock_context); @@ -5278,7 +5278,7 @@ TEST_F(LayerTreeHostImplTest, NoPartialSwap) { { LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); } Mock::VerifyAndClearExpectations(&mock_context); @@ -5300,7 +5300,7 @@ TEST_F(LayerTreeHostImplTest, PartialSwap) { { LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); } Mock::VerifyAndClearExpectations(&mock_context); @@ -5315,7 +5315,7 @@ TEST_F(LayerTreeHostImplTest, PartialSwap) { { LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); } Mock::VerifyAndClearExpectations(&mock_context); @@ -5420,7 +5420,7 @@ TEST_F(LayerTreeHostImplTest, ContributingLayerEmptyScissorPartialSwap) { EXPECT_EQ(DrawQuad::RENDER_PASS, frame.render_passes[1]->quad_list.front()->material); - my_host_impl->DrawLayers(&frame, gfx::FrameTime::Now()); + my_host_impl->DrawLayers(&frame); my_host_impl->DidDrawAllLayers(frame); } } @@ -5447,7 +5447,7 @@ TEST_F(LayerTreeHostImplTest, ContributingLayerEmptyScissorNoPartialSwap) { EXPECT_EQ(DrawQuad::RENDER_PASS, frame.render_passes[1]->quad_list.front()->material); - my_host_impl->DrawLayers(&frame, gfx::FrameTime::Now()); + my_host_impl->DrawLayers(&frame); my_host_impl->DidDrawAllLayers(frame); } } @@ -5491,7 +5491,7 @@ TEST_F(LayerTreeHostImplTest, LayersFreeTextures) { LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); host_impl_->SwapBuffers(frame); @@ -5534,7 +5534,7 @@ TEST_F(LayerTreeHostImplTest, HasTransparentBackground) { .Times(1); LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); Mock::VerifyAndClearExpectations(&mock_context); @@ -5542,7 +5542,7 @@ TEST_F(LayerTreeHostImplTest, HasTransparentBackground) { host_impl_->active_tree()->set_has_transparent_background(true); host_impl_->SetFullRootLayerDamage(); EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); Mock::VerifyAndClearExpectations(&mock_context); } @@ -5625,7 +5625,7 @@ class LayerTreeHostImplTestWithDelegatingRenderer root_render_pass->quad_list.ElementAt(1)->visible_rect); } - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); EXPECT_EQ(expect_to_draw, host_impl_->SwapBuffers(frame)); } @@ -5759,7 +5759,7 @@ TEST_F(LayerTreeHostImplTest, FarAwayQuadsDontNeedAA) { quad->quadTransform(), quad, false); EXPECT_FALSE(antialiased); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); } @@ -5781,7 +5781,7 @@ TEST_F(CompositorFrameMetadataTest, CompositorFrameAckCountsAsSwapComplete) { { LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, base::TimeTicks()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); } CompositorFrameAck ack; @@ -5876,7 +5876,7 @@ TEST_F(LayerTreeHostImplTest, LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); EXPECT_EQ(1u, frame.will_draw_layers.size()); @@ -6110,7 +6110,7 @@ TEST_F(LayerTreeHostImplTest, ShutdownReleasesContext) { LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); // The CopyOutputResult's callback has a ref on the ContextProvider and a @@ -6507,7 +6507,7 @@ TEST_F(LayerTreeHostImplTest, LatencyInfoPassedToCompositorFrameMetadata) { gfx::Rect full_frame_damage(host_impl_->DrawViewportSize()); LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); EXPECT_TRUE(host_impl_->SwapBuffers(frame)); @@ -6555,7 +6555,7 @@ TEST_F(LayerTreeHostImplTest, SelectionBoundsPassedToCompositorFrameMetadata) { gfx::Rect full_frame_damage(host_impl_->DrawViewportSize()); LayerTreeHostImpl::FrameData frame; EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame)); - host_impl_->DrawLayers(&frame, gfx::FrameTime::Now()); + host_impl_->DrawLayers(&frame); host_impl_->DidDrawAllLayers(frame); EXPECT_TRUE(host_impl_->SwapBuffers(frame)); diff --git a/cc/trees/single_thread_proxy.cc b/cc/trees/single_thread_proxy.cc index b97b3ce..855d980 100644 --- a/cc/trees/single_thread_proxy.cc +++ b/cc/trees/single_thread_proxy.cc @@ -632,7 +632,7 @@ void SingleThreadProxy::CompositeImmediately(base::TimeTicks frame_begin_time) { DoAnimate(); LayerTreeHostImpl::FrameData frame; - DoComposite(frame_begin_time, &frame); + DoComposite(&frame); // DoComposite could abort, but because this is a synchronous composite // another draw will never be scheduled, so break remaining promises. @@ -674,8 +674,7 @@ void SingleThreadProxy::ScheduleRequestNewOutputSurface() { } } -DrawResult SingleThreadProxy::DoComposite(base::TimeTicks frame_begin_time, - LayerTreeHostImpl::FrameData* frame) { +DrawResult SingleThreadProxy::DoComposite(LayerTreeHostImpl::FrameData* frame) { TRACE_EVENT0("cc", "SingleThreadProxy::DoComposite"); DCHECK(!layer_tree_host_->output_surface_lost()); @@ -714,7 +713,7 @@ DrawResult SingleThreadProxy::DoComposite(base::TimeTicks frame_begin_time, tracked_objects::ScopedTracker tracking_profile3( FROM_HERE_WITH_EXPLICIT_FUNCTION( "461509 SingleThreadProxy::DoComposite3")); - layer_tree_host_impl_->DrawLayers(frame, frame_begin_time); + layer_tree_host_impl_->DrawLayers(frame); } // TODO(robliao): Remove ScopedTracker below once https://crbug.com/461509 // is fixed. @@ -915,8 +914,7 @@ void SingleThreadProxy::BeginMainFrameAbortedOnImplThread( DrawResult SingleThreadProxy::ScheduledActionDrawAndSwapIfPossible() { DebugScopedSetImplThread impl(this); LayerTreeHostImpl::FrameData frame; - return DoComposite(layer_tree_host_impl_->CurrentBeginFrameArgs().frame_time, - &frame); + return DoComposite(&frame); } DrawResult SingleThreadProxy::ScheduledActionDrawAndSwapForced() { diff --git a/cc/trees/single_thread_proxy.h b/cc/trees/single_thread_proxy.h index cd80a1c..a148fef 100644 --- a/cc/trees/single_thread_proxy.h +++ b/cc/trees/single_thread_proxy.h @@ -134,8 +134,7 @@ class CC_EXPORT SingleThreadProxy : public Proxy, void DoAnimate(); void DoBeginMainFrame(const BeginFrameArgs& begin_frame_args); void DoCommit(); - DrawResult DoComposite(base::TimeTicks frame_begin_time, - LayerTreeHostImpl::FrameData* frame); + DrawResult DoComposite(LayerTreeHostImpl::FrameData* frame); void DoSwap(); void DidCommitAndDrawFrame(); void CommitComplete(); diff --git a/cc/trees/thread_proxy.cc b/cc/trees/thread_proxy.cc index db4091c..bd1d235 100644 --- a/cc/trees/thread_proxy.cc +++ b/cc/trees/thread_proxy.cc @@ -1087,8 +1087,7 @@ DrawResult ThreadProxy::DrawSwapInternal(bool forced_draw) { } if (draw_frame) { - impl().layer_tree_host_impl->DrawLayers( - &frame, impl().scheduler->LastBeginImplFrameTime()); + impl().layer_tree_host_impl->DrawLayers(&frame); result = DRAW_SUCCESS; } else { DCHECK_NE(DRAW_SUCCESS, result); |