diff options
| author | enne@chromium.org <enne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-13 08:46:38 +0000 |
|---|---|---|
| committer | enne@chromium.org <enne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-13 08:46:38 +0000 |
| commit | 3f52c8939a06c00f692cf2c9fcc15df33367c977 (patch) | |
| tree | a4d7de53da63c9cf233e1750dba8bffc712163d9 /cc | |
| parent | 093ffd63eb6b3ee849399f8e3a008e18594288d0 (diff) | |
| download | chromium_src-3f52c8939a06c00f692cf2c9fcc15df33367c977.zip chromium_src-3f52c8939a06c00f692cf2c9fcc15df33367c977.tar.gz chromium_src-3f52c8939a06c00f692cf2c9fcc15df33367c977.tar.bz2 | |
cc: Presubmit ban #if 0
R=danakj@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/338463004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276977 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc')
| -rw-r--r-- | cc/PRESUBMIT.py | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py index 6a7f921..3397313 100644 --- a/cc/PRESUBMIT.py +++ b/cc/PRESUBMIT.py @@ -149,6 +149,19 @@ def FindUnquotedQuote(contents, pos): match = re.search(r"(?<!\\)(?P<quote>\")", contents[pos:]) return -1 if not match else match.start("quote") + pos +def FindUselessIfdefs(input_api, output_api): + errors = [] + source_file_filter = lambda x: x + for f in input_api.AffectedSourceFiles(source_file_filter): + contents = input_api.ReadFile(f, 'rb') + if re.search(r'#if\s*0\s', contents): + errors.append(f.LocalPath()) + if errors: + return [output_api.PresubmitError( + 'Don\'t use #if '+'0; just delete the code.', + items=errors)] + return [] + def FindNamespaceInBlock(pos, namespace, contents, whitelist=[]): open_brace = -1 close_brace = -1 @@ -274,6 +287,7 @@ def CheckChangeOnUpload(input_api, output_api): results += CheckTodos(input_api, output_api) results += CheckNamespace(input_api, output_api) results += CheckForUseOfWrongClock(input_api, output_api) + results += FindUselessIfdefs(input_api, output_api) results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) return results |