diff options
| author | sohan.jyoti@samsung.com <sohan.jyoti@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-11 19:39:53 +0000 |
|---|---|---|
| committer | sohan.jyoti@samsung.com <sohan.jyoti@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-11 19:39:53 +0000 |
| commit | ceaf37044cb7be4d4460654a53f3c3dc1ad46a90 (patch) | |
| tree | 59b2251a268653f38600ac41afb7d5f7f268c6bc /cc | |
| parent | a4aac089e5ee325d101af23571622131c9807e46 (diff) | |
| download | chromium_src-ceaf37044cb7be4d4460654a53f3c3dc1ad46a90.zip chromium_src-ceaf37044cb7be4d4460654a53f3c3dc1ad46a90.tar.gz chromium_src-ceaf37044cb7be4d4460654a53f3c3dc1ad46a90.tar.bz2 | |
cc: Log pngs in pixel test only if they are different.
BUG=
Review URL: https://codereview.chromium.org/385083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282666 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc')
| -rw-r--r-- | cc/test/pixel_test_utils.cc | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/cc/test/pixel_test_utils.cc b/cc/test/pixel_test_utils.cc index 9fbc86a..a0ddad3 100644 --- a/cc/test/pixel_test_utils.cc +++ b/cc/test/pixel_test_utils.cc @@ -72,13 +72,15 @@ bool MatchesPNGFile(const SkBitmap& gen_bmp, base::FilePath ref_img_path, if (gen_bmp.width() == 0 || gen_bmp.height() == 0) return true; - std::string gen_bmp_data_url = GetPNGDataUrl(gen_bmp); - std::string ref_bmp_data_url = GetPNGDataUrl(ref_bmp); - LOG(ERROR) << "Pixels do not match!"; - LOG(ERROR) << "Actual: " << gen_bmp_data_url; - LOG(ERROR) << "Expected: " << ref_bmp_data_url; - - return comparator.Compare(gen_bmp, ref_bmp); + bool compare = comparator.Compare(gen_bmp, ref_bmp); + if (!compare) { + std::string gen_bmp_data_url = GetPNGDataUrl(gen_bmp); + std::string ref_bmp_data_url = GetPNGDataUrl(ref_bmp); + LOG(ERROR) << "Pixels do not match!"; + LOG(ERROR) << "Actual: " << gen_bmp_data_url; + LOG(ERROR) << "Expected: " << ref_bmp_data_url; + } + return compare; } } // namespace cc |