summaryrefslogtreecommitdiffstats
path: root/cc
diff options
context:
space:
mode:
authorjdonnelly <jdonnelly@chromium.org>2015-04-23 13:52:49 -0700
committerCommit bot <commit-bot@chromium.org>2015-04-23 20:52:58 +0000
commitf2f043dcd893c280bbf8a2da9abf87c7abb50460 (patch)
treec42df4eb62b5d1c849de15119332fb01df567da0 /cc
parent6d8a562e40f10b2a1e4c49f3f56c7578e3bb070d (diff)
downloadchromium_src-f2f043dcd893c280bbf8a2da9abf87c7abb50460.zip
chromium_src-f2f043dcd893c280bbf8a2da9abf87c7abb50460.tar.gz
chromium_src-f2f043dcd893c280bbf8a2da9abf87c7abb50460.tar.bz2
Revert of ui: Cache the output of View::OnPaint when the View isn't invalid. (patchset #4 id:80001 of https://codereview.chromium.org/1101783002/)
Reason for revert: ash_unittests are timing out on Win8 Aura and Linux ChromiumOS Tests (dbg)(1) bots. Reverting this CL in order to revert https://codereview.chromium.org/1080633009/ which we suspect to be the cause of the problem. Original issue's description: > ui: Cache the output of View::OnPaint when the View isn't invalid. > > Store the output of View::OnPaint as a PaintCache object, and when the > view has not been invalidated, use that cache output instead of doing > work to build a recording. > > Performance data as follows when the loading spinner is going: > > Before impl-side (TOT): 0.13ms / paint > With impl-side (no slimming paint): 0.22ms / paint > With impl-side and slimming paint (this patch): 0.17ms / paint > > So this gets us some of the way there. I need to investigate why it's > not doing more. > > R=piman@chromium.org, sky > BUG=466426 > > Committed: https://crrev.com/7f686cdcff81d6779b962e98e529a7360be2809c > Cr-Commit-Position: refs/heads/master@{#326592} TBR=piman@chromium.org,sky@chromium.org,danakj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466426 Review URL: https://codereview.chromium.org/1108463002 Cr-Commit-Position: refs/heads/master@{#326636}
Diffstat (limited to 'cc')
-rw-r--r--cc/resources/drawing_display_item.cc4
-rw-r--r--cc/resources/drawing_display_item.h2
2 files changed, 0 insertions, 6 deletions
diff --git a/cc/resources/drawing_display_item.cc b/cc/resources/drawing_display_item.cc
index a37729f..91ab3fb 100644
--- a/cc/resources/drawing_display_item.cc
+++ b/cc/resources/drawing_display_item.cc
@@ -62,8 +62,4 @@ void DrawingDisplayItem::AsValueInto(
array->EndDictionary();
}
-scoped_ptr<DrawingDisplayItem> DrawingDisplayItem::Clone() {
- return Create(picture_);
-}
-
} // namespace cc
diff --git a/cc/resources/drawing_display_item.h b/cc/resources/drawing_display_item.h
index da302d8..a3eef77 100644
--- a/cc/resources/drawing_display_item.h
+++ b/cc/resources/drawing_display_item.h
@@ -33,8 +33,6 @@ class CC_EXPORT DrawingDisplayItem : public DisplayItem {
size_t PictureMemoryUsage() const override;
void AsValueInto(base::trace_event::TracedValue* array) const override;
- scoped_ptr<DrawingDisplayItem> Clone();
-
protected:
explicit DrawingDisplayItem(skia::RefPtr<SkPicture> picture);