diff options
| author | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-18 02:16:59 +0000 |
|---|---|---|
| committer | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-18 02:16:59 +0000 |
| commit | 16f47e08060635631f1ad2cbb30906beb1caffc3 (patch) | |
| tree | f2e07ada71f47383cb8355091b0a92e090c8656e /ceee | |
| parent | 9fb09e0cb9a33db85884f3f81e406d12ad9f2b70 (diff) | |
| download | chromium_src-16f47e08060635631f1ad2cbb30906beb1caffc3.zip chromium_src-16f47e08060635631f1ad2cbb30906beb1caffc3.tar.gz chromium_src-16f47e08060635631f1ad2cbb30906beb1caffc3.tar.bz2 | |
Made return types of various Value::DeepCopy() implementations more specific
Since C++ supports covariant return types, a subclass of Value can return its
own pointer type for Value::DeepCopy().
Also made signatures of Value::Create*Value() more specific.
Removed now-unnecessary casts.
Added test for covariant return types.
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6324004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71617 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ceee')
| -rw-r--r-- | ceee/ie/broker/window_api_module.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ceee/ie/broker/window_api_module.cc b/ceee/ie/broker/window_api_module.cc index b211244..7df5411 100644 --- a/ceee/ie/broker/window_api_module.cc +++ b/ceee/ie/broker/window_api_module.cc @@ -265,7 +265,7 @@ void CreateWindowFunc::Execute(const ListValue& args, int request_id) { return; } // Remember the arguments so that we can use them later. - input_dict.reset(static_cast<DictionaryValue*>(args_dict->DeepCopy())); + input_dict.reset(args_dict->DeepCopy()); } } |