diff options
| author | mad@google.com <mad@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-07 16:49:16 +0000 |
|---|---|---|
| committer | mad@google.com <mad@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-07 16:49:16 +0000 |
| commit | 8b21080ae97787dfe73068014bce3c9e0343eb36 (patch) | |
| tree | eba4da9f4d58eb04ddced35bf5d3e2166e3f2b80 /ceee | |
| parent | 4c9abdb7f2f33059a575abd55548b457bcad9fd8 (diff) | |
| download | chromium_src-8b21080ae97787dfe73068014bce3c9e0343eb36.zip chromium_src-8b21080ae97787dfe73068014bce3c9e0343eb36.tar.gz chromium_src-8b21080ae97787dfe73068014bce3c9e0343eb36.tar.bz2 | |
Quick fix to properly report error to Chrome Extensions...
I fear this might cause trouble in the Chrome Extensions code if some requests never get their answer and it caused a DCHECK in debug that is annoying when investigating other things...
BUG=65440
TEST=None
Review URL: http://codereview.chromium.org/5576007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68481 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ceee')
| -rw-r--r-- | ceee/ie/broker/tab_api_module.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/ceee/ie/broker/tab_api_module.cc b/ceee/ie/broker/tab_api_module.cc index 420007e..c2ac61f 100644 --- a/ceee/ie/broker/tab_api_module.cc +++ b/ceee/ie/broker/tab_api_module.cc @@ -333,7 +333,7 @@ HRESULT TabApiResult::IsTabFromSameOrUnspecifiedFrameWindow( DCHECK(dispatcher != NULL); if (!dispatcher->IsTabIdValid(tab_id)) { // This can happen if the tab died before we get here. - LOG(WARNING) << "Ta ID: " << tab_id << ", not recognized."; + LOG(WARNING) << "Tab ID: " << tab_id << ", not recognized."; return E_UNEXPECTED; } HWND input_tab_window = dispatcher->GetTabHandleFromId(tab_id); @@ -1011,6 +1011,7 @@ HRESULT CreateTab::ContinueExecution(const std::string& input_args, if (FAILED(hr)) { // The ApiDispatcher will forget about us and result's destructor will // free the allocation of user_data. + result->PostError("Internal error while trying to finish tab creation."); return hr; } if (hr == S_FALSE) { |