diff options
| author | jbudorick <jbudorick@chromium.org> | 2015-10-23 13:54:40 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-23 20:56:19 +0000 |
| commit | 77a03f6624a369d01b565b46e3584d25ae41fb0b (patch) | |
| tree | dca800e84224c1a04139811a798c4c7dee777fc3 /chrome/android/BUILD.gn | |
| parent | efac61aadc057f6e98ba628e68e5ad1d5c76053e (diff) | |
| download | chromium_src-77a03f6624a369d01b565b46e3584d25ae41fb0b.zip chromium_src-77a03f6624a369d01b565b46e3584d25ae41fb0b.tar.gz chromium_src-77a03f6624a369d01b565b46e3584d25ae41fb0b.tar.bz2 | |
Revert of Reland Switch Chrome Android using v8 arch specific external data name (patchset #3 id:40001 of https://codereview.chromium.org/1417753004/ )
Reason for revert:
broke gpu bots: https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%206%29/builds/3712
Original issue's description:
> Orignal patch
> https://codereview.chromium.org/1400953002/
>
> Switch Chrome Android using v8 arch specific external data name
>
> For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used.
> For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used.
>
> This patch also removed the existing v8 startup data in
> destination directory by using copy_ex to remove directory
> first.
>
> BUG=540788
> TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org
>
> Committed: https://crrev.com/ed31140dee44c06e6398e92e1afb9c047c9137e6
> Cr-Commit-Position: refs/heads/master@{#355843}
TBR=michaelbai@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=540788
Review URL: https://codereview.chromium.org/1421893002
Cr-Commit-Position: refs/heads/master@{#355877}
Diffstat (limited to 'chrome/android/BUILD.gn')
| -rw-r--r-- | chrome/android/BUILD.gn | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn index 1229c40..7480244 100644 --- a/chrome/android/BUILD.gn +++ b/chrome/android/BUILD.gn @@ -357,8 +357,10 @@ copy_ex("chrome_public_apk_assets") { ] if (v8_use_external_startup_data) { - renaming_sources = v8_external_startup_data_renaming_sources - renaming_destinations = v8_external_startup_data_renaming_destinations + sources += [ + "$root_out_dir/natives_blob.bin", + "$root_out_dir/snapshot_blob.bin", + ] deps += [ "//v8" ] } |