diff options
author | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-15 02:04:21 +0000 |
---|---|---|
committer | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-15 02:04:21 +0000 |
commit | 0abe2cbeb51078bf2f14496fac9a1d7a2e21a919 (patch) | |
tree | 17cbd45a663de156b1d1f15f9c3d855a9d2782d5 /chrome/app/breakpad_linux.cc | |
parent | d0620522264c47074c3602fa8dfb7ad5fbf64e64 (diff) | |
download | chromium_src-0abe2cbeb51078bf2f14496fac9a1d7a2e21a919.zip chromium_src-0abe2cbeb51078bf2f14496fac9a1d7a2e21a919.tar.gz chromium_src-0abe2cbeb51078bf2f14496fac9a1d7a2e21a919.tar.bz2 |
Change breakpads on the helper processes to keep our rimZ clean.
Initialize crash reporting in helper processes such as the renderer process.
Renderer crash reporting stopped working in r23006 when multiple .app bundles
were introduced, because the stats collection and crash reporting preference
is presently accessed via NSUserDefaults, keyed on the bundle ID. The main
browser process and helper processes have distinct bundle IDs. In the new
scheme, only the main browser process consults this preference, and passes it
to helper processes in their command lines.
BUG=19204
TEST=When reporting is enabled, Breakpad should pick up browser and renderer
process crashes;
When reporting is enabled, renderer should not log messages like
[mmdd/hhmmss:WARNING:/path/to/breakpad_mac.mm(47)] Breakpad disabled;
When reporting is disabled, browser and renderer should both log these
messages.
Review URL: http://codereview.chromium.org/165546
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23509 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app/breakpad_linux.cc')
-rw-r--r-- | chrome/app/breakpad_linux.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/app/breakpad_linux.cc b/chrome/app/breakpad_linux.cc index b23a5d7..19c82ba 100644 --- a/chrome/app/breakpad_linux.cc +++ b/chrome/app/breakpad_linux.cc @@ -611,11 +611,11 @@ void InitCrashReporter() { // We might be chrooted in a zygote or renderer process so we cannot call // GetCollectStatsConsent because that needs access the the user's home // dir. Instead, we set a command line flag for these processes. - if (!parsed_command_line.HasSwitch(switches::kRendererCrashDump)) + if (!parsed_command_line.HasSwitch(switches::kEnableCrashReporter)) return; // Get the guid and linux distro from the command line switch. std::string switch_value = WideToASCII( - parsed_command_line.GetSwitchValue(switches::kRendererCrashDump)); + parsed_command_line.GetSwitchValue(switches::kEnableCrashReporter)); size_t separator = switch_value.find(","); if (separator != std::string::npos) { google_update::linux_guid = switch_value.substr(0, separator); |