diff options
author | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-15 02:04:21 +0000 |
---|---|---|
committer | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-15 02:04:21 +0000 |
commit | 0abe2cbeb51078bf2f14496fac9a1d7a2e21a919 (patch) | |
tree | 17cbd45a663de156b1d1f15f9c3d855a9d2782d5 /chrome/app/breakpad_mac.h | |
parent | d0620522264c47074c3602fa8dfb7ad5fbf64e64 (diff) | |
download | chromium_src-0abe2cbeb51078bf2f14496fac9a1d7a2e21a919.zip chromium_src-0abe2cbeb51078bf2f14496fac9a1d7a2e21a919.tar.gz chromium_src-0abe2cbeb51078bf2f14496fac9a1d7a2e21a919.tar.bz2 |
Change breakpads on the helper processes to keep our rimZ clean.
Initialize crash reporting in helper processes such as the renderer process.
Renderer crash reporting stopped working in r23006 when multiple .app bundles
were introduced, because the stats collection and crash reporting preference
is presently accessed via NSUserDefaults, keyed on the bundle ID. The main
browser process and helper processes have distinct bundle IDs. In the new
scheme, only the main browser process consults this preference, and passes it
to helper processes in their command lines.
BUG=19204
TEST=When reporting is enabled, Breakpad should pick up browser and renderer
process crashes;
When reporting is enabled, renderer should not log messages like
[mmdd/hhmmss:WARNING:/path/to/breakpad_mac.mm(47)] Breakpad disabled;
When reporting is disabled, browser and renderer should both log these
messages.
Review URL: http://codereview.chromium.org/165546
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23509 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app/breakpad_mac.h')
-rw-r--r-- | chrome/app/breakpad_mac.h | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/chrome/app/breakpad_mac.h b/chrome/app/breakpad_mac.h index 8872191..ce6f25f 100644 --- a/chrome/app/breakpad_mac.h +++ b/chrome/app/breakpad_mac.h @@ -5,8 +5,6 @@ #ifndef CHROME_APP_BREAKPAD_MAC_H_ #define CHROME_APP_BREAKPAD_MAC_H_ -extern "C" { - // This header defines the Chrome entry points for Breakpad integration. // Initializes Breakpad. @@ -23,7 +21,7 @@ bool IsCrashReporterDisabled(); // Call on clean process shutdown. void DestructCrashReporter(); -#if __OBJC__ +#ifdef __OBJC__ @class NSString; @@ -36,6 +34,4 @@ void ClearCrashKeyValue(NSString* key); #endif // __OBJC__ -} - #endif // CHROME_APP_BREAKPAD_MAC_H_ |