summaryrefslogtreecommitdiffstats
path: root/chrome/app/breakpad_mac.mm
diff options
context:
space:
mode:
authorjeremy@chromium.org <jeremy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-03 23:10:16 +0000
committerjeremy@chromium.org <jeremy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-03 23:10:16 +0000
commit3363ebc7fd18549109caaa8322edf512a8b11818 (patch)
treecdff4fba143657a9619f3c68baf9d4de937cc558 /chrome/app/breakpad_mac.mm
parent052212838598dff1ae487e654016da0771b9d975 (diff)
downloadchromium_src-3363ebc7fd18549109caaa8322edf512a8b11818.zip
chromium_src-3363ebc7fd18549109caaa8322edf512a8b11818.tar.gz
chromium_src-3363ebc7fd18549109caaa8322edf512a8b11818.tar.bz2
Fix for extra BreakPad param upload on OSX
A change in Breakpad upstream caused the custom key/value pairs we specified to no longer be sent to crash server (e.g. process type). This change pulls in an upstream fix and causes our code to use new APIs to specify this information. BUG=13131 TEST=Crash breakpad, look at crash dump on crash server, make sure pytpe field is present. Review URL: http://codereview.chromium.org/119121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17563 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app/breakpad_mac.mm')
-rw-r--r--chrome/app/breakpad_mac.mm9
1 files changed, 5 insertions, 4 deletions
diff --git a/chrome/app/breakpad_mac.mm b/chrome/app/breakpad_mac.mm
index bda33fe4..6d28d47 100644
--- a/chrome/app/breakpad_mac.mm
+++ b/chrome/app/breakpad_mac.mm
@@ -31,11 +31,12 @@ void BreakpadRelease(BreakpadRef ref) {
NOTREACHED();
}
-void BreakpadSetKeyValue(BreakpadRef ref, NSString *key, NSString *value) {
+void BreakpadAddUploadParameter(BreakpadRef ref, NSString *key,
+ NSString *value) {
NOTREACHED();
}
-void BreakpadRemoveKeyValue(BreakpadRef ref, NSString *key) {
+void BreakpadRemoveUploadParameter(BreakpadRef ref, NSString *key) {
NOTREACHED();
}
@@ -140,7 +141,7 @@ void SetCrashKeyValue(NSString* key, NSString* value) {
return;
}
- BreakpadSetKeyValue(gBreakpadRef, key, value);
+ BreakpadAddUploadParameter(gBreakpadRef, key, value);
}
void ClearCrashKeyValue(NSString* key) {
@@ -148,5 +149,5 @@ void ClearCrashKeyValue(NSString* key) {
return;
}
- BreakpadRemoveKeyValue(gBreakpadRef, key);
+ BreakpadRemoveUploadParameter(gBreakpadRef, key);
}