diff options
author | chrisha@chromium.org <chrisha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-20 04:35:42 +0000 |
---|---|---|
committer | chrisha@chromium.org <chrisha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-20 04:35:42 +0000 |
commit | 8e5d5183339a4ed9869db83069ea8f40a6e7dab2 (patch) | |
tree | 08afa5eb193d691a2cec77c89872c133c1a00b70 /chrome/app/client_util.cc | |
parent | 555c2727afde2f81734a499ca98934e22b2045dc (diff) | |
download | chromium_src-8e5d5183339a4ed9869db83069ea8f40a6e7dab2.zip chromium_src-8e5d5183339a4ed9869db83069ea8f40a6e7dab2.tar.gz chromium_src-8e5d5183339a4ed9869db83069ea8f40a6e7dab2.tar.bz2 |
Roll back PreRead experiment
This CL removes the pre-read experiment introduced in revision 95579.
http://src.chromium.org/viewvc/chrome?view=rev&revision=95579
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7690007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97556 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app/client_util.cc')
-rw-r--r-- | chrome/app/client_util.cc | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/chrome/app/client_util.cc b/chrome/app/client_util.cc index db02eb3..8ef4ee0 100644 --- a/chrome/app/client_util.cc +++ b/chrome/app/client_util.cc @@ -11,7 +11,6 @@ #include "base/file_util.h" #include "base/logging.h" #include "base/memory/scoped_ptr.h" -#include "base/rand_util.h" // For PreReadExperiment. #include "base/string_util.h" #include "base/utf_string_conversions.h" #include "base/version.h" @@ -139,25 +138,6 @@ HMODULE LoadChromeWithDirectory(std::wstring* dir) { key.Close(); } - // The Syzygy project is a competing optimization technique. Part of the - // evaluation consists of an A/B experiment. As a baseline, we wish to - // evaluate startup time with preread enabled and disabled. We can't use - // base::FieldTrial as this only exists *after* chrome.dll is loaded. We - // override the registry setting with a coin-toss for the duration of the - // experiment. - // NOTE: This experiment is intended for Canary and Dev only, and should be - // removed from any branch heading out to beta and beyond! - pre_read = base::RandInt(0, 1); - DCHECK(pre_read == 0 || pre_read == 1); - - // We communicate the coin-toss result via a side-channel - // (environment variable) to chrome.dll. This ensures that chrome.dll - // only reports experiment results if it has been launched by a - // chrome.exe that is actually running the experiment. - scoped_ptr<base::Environment> env(base::Environment::Create()); - DCHECK(env.get() != NULL); - env->SetVar("CHROME_PRE_READ_EXPERIMENT", pre_read ? "1" : "0"); - if (pre_read) { TRACE_EVENT_BEGIN_ETW("PreReadImage", 0, ""); file_util::PreReadImage(dir->c_str(), pre_read_size, pre_read_step_size); |