Make chrome.exe read version from Software\Chromium instead of Google Update keys when running Chromium. With this change

now we can build a Chromium release that gets installed under Application Data\Chromium and actually runs.
- Added a new file that has common functions used by google update client and chromium
- Did some minor cleanup based on readability guidelines (alphabatical order etc).
- We seem to be trying to avoid std::wstring at some places but are using it at other places. In future we should be just able to use std::wstring and get rid of StringCchDup.

BUG=1296800


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1243 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 90 insertions, 0 deletions

diff --git a/chrome/app/client_util.cc b/chrome/app/client_util.cc
new file mode 100644
index 0000000..4a34085
--- /dev/null
+++ b/chrome/app/client_util.cc
@@ -0,0 +1,90 @@
+// Copyright 2008, Google Inc.
+// All rights reserved.
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+//    * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+//    * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following disclaimer
+// in the documentation and/or other materials provided with the
+// distribution.
+//    * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived from
+// this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+#include "chrome/app/client_util.h"
+
+#include <shlobj.h>
+
+namespace client_util {
+const wchar_t kProductVersionKey[] = L"pv";
+
+bool FileExists(const wchar_t* const file_path) {
+  WIN32_FILE_ATTRIBUTE_DATA attrs;
+  return ::GetFileAttributesEx(file_path, GetFileExInfoStandard, &attrs) != 0;
+}
+
+bool GetChromiumVersion(const wchar_t* const exe_path,
+                        const wchar_t* const reg_key_path,
+                        wchar_t** version) {
+  HKEY reg_root = IsUserModeInstall(exe_path) ? HKEY_CURRENT_USER :
+                                                HKEY_LOCAL_MACHINE;
+  HKEY reg_key;
+  if (::RegOpenKeyEx(reg_root, reg_key_path, 0,
+                     KEY_READ, &reg_key) != ERROR_SUCCESS) {
+    return false;
+  }
+  DWORD size = 0;
+  bool ret = false;
+  if (::RegQueryValueEx(reg_key, client_util::kProductVersionKey, NULL, NULL,
+                        NULL, &size) == ERROR_SUCCESS) {
+    *version = new wchar_t[1 + (size / sizeof(wchar_t))];
+    if (::RegQueryValueEx(reg_key, client_util::kProductVersionKey,
+                          NULL, NULL, reinterpret_cast<BYTE*>(*version),
+                          &size) == ERROR_SUCCESS) {
+      ret = true;
+    } else {
+      delete[] *version;
+    }
+  }
+  ::RegCloseKey(reg_key);
+  return ret;
+}
+
+void GetExecutablePath(wchar_t* exe_path) {
+  DWORD len = ::GetModuleFileName(NULL, exe_path, MAX_PATH);
+  wchar_t* tmp = exe_path + len - 1;
+  while (tmp >= exe_path && *tmp != L'\\')
+    tmp--;
+  if (tmp > exe_path) {
+    tmp++;
+    *tmp = 0;
+  }
+}
+
+bool IsUserModeInstall(const wchar_t* const exe_path) {
+  wchar_t buffer[MAX_PATH] = {0};
+  if (!FAILED(SHGetFolderPath(NULL, CSIDL_PROGRAM_FILES, NULL,
+                              SHGFP_TYPE_CURRENT, buffer))) {
+    if (exe_path == wcsstr(exe_path, buffer)) {
+      return false;
+    }
+  }
+  return true;
+}
+}  // namespace client_util