diff options
| author | toyoshim@chromium.org <toyoshim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-24 02:49:17 +0000 |
|---|---|---|
| committer | toyoshim@chromium.org <toyoshim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-24 02:49:17 +0000 |
| commit | 7f4c84ffe959733ebe3fe1e6c5ea2c65a2dc218f (patch) | |
| tree | 1d273f5e372cad599d860b22be4ea3ec2bc7486e /chrome/app/nibs/Toolbar.xib | |
| parent | ee2408b9230399f65a42107f230dde7a70f934e4 (diff) | |
| download | chromium_src-7f4c84ffe959733ebe3fe1e6c5ea2c65a2dc218f.zip chromium_src-7f4c84ffe959733ebe3fe1e6c5ea2c65a2dc218f.tar.gz chromium_src-7f4c84ffe959733ebe3fe1e6c5ea2c65a2dc218f.tar.bz2 | |
[Mac] Middle clicking on home button does not work. It should open home in new
tab. backward button, forward button and reload button have the same problem.
XIB Changes:
* Add ToolbarButton for buttons which should handle middle clicking.
* Switch the home button to be ToolbarButton instead of NSButton.
* Back/forward and reload buttons inherit from ToolbarButton instead of
NSButton.
BUG=45795
TEST=Middle click on the home button create new tab with home page, or on the
reload button create new tab with current page. Middle click on the
back/forward buttons also work with new tab. unit_tests include
TestbarButtonTest.* suites for testint that.
R=pinkerton@chromium.org,avi@chromium.org,viettrungluu@chromium.org,mark@chromium.org,shess@chromium.org,rohitrao@chromium.org
Review URL: http://codereview.chromium.org/6703004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79245 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app/nibs/Toolbar.xib')
| -rw-r--r-- | chrome/app/nibs/Toolbar.xib | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/chrome/app/nibs/Toolbar.xib b/chrome/app/nibs/Toolbar.xib index c8aa93b..83fa105 100644 --- a/chrome/app/nibs/Toolbar.xib +++ b/chrome/app/nibs/Toolbar.xib @@ -2,7 +2,7 @@ <archive type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="7.10"> <data> <int key="IBDocument.SystemTarget">1050</int> - <string key="IBDocument.SystemVersion">10F2108</string> + <string key="IBDocument.SystemVersion">10F569</string> <string key="IBDocument.InterfaceBuilderVersion">823</string> <string key="IBDocument.AppKitVersion">1038.29</string> <string key="IBDocument.HIToolboxVersion">461.00</string> @@ -12,9 +12,9 @@ </object> <object class="NSMutableArray" key="IBDocument.EditedObjectIDs"> <bool key="EncodedWithXMLCoder">YES</bool> + <integer value="208"/> <integer value="1"/> <integer value="211"/> - <integer value="208"/> </object> <object class="NSArray" key="IBDocument.PluginDependencies"> <bool key="EncodedWithXMLCoder">YES</bool> @@ -1209,6 +1209,7 @@ <string>7.CustomClassName</string> <string>7.IBAttributePlaceholdersKey</string> <string>7.IBPluginDependency</string> + <string>8.CustomClassName</string> <string>8.IBAttributePlaceholdersKey</string> <string>8.IBPluginDependency</string> <string>9.CustomClassName</string> @@ -1314,6 +1315,7 @@ </object> </object> <string>com.apple.InterfaceBuilder.CocoaPlugin</string> + <string>ToolbarButton</string> <object class="NSMutableDictionary"> <string key="NS.key.0">ToolTip</string> <object class="IBToolTipAttribute" key="NS.object.0"> @@ -1550,6 +1552,14 @@ </object> </object> <object class="IBPartialClassDescription"> + <string key="className">ToolbarButton</string> + <string key="superclassName">NSButton</string> + <object class="IBClassDescriptionSource" key="sourceIdentifier"> + <string key="majorKey">IBProjectSource</string> + <string key="minorKey">browser/ui/cocoa/toolbar/toolbar_button.h</string> + </object> + </object> + <object class="IBPartialClassDescription"> <string key="className">MenuButton</string> <string key="superclassName">NSButton</string> <object class="NSMutableDictionary" key="outlets"> @@ -1711,7 +1721,7 @@ </object> <object class="IBToOneOutletInfo"> <string key="name">homeButton_</string> - <string key="candidateClassName">NSButton</string> + <string key="candidateClassName">ToolbarButton</string> </object> <object class="IBToOneOutletInfo"> <string key="name">locationBar_</string> |