diff options
| author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-26 00:07:04 +0000 |
|---|---|---|
| committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-26 00:07:04 +0000 |
| commit | e59a1c4503496f843391641dbb947043dec2a466 (patch) | |
| tree | 9e775066cfb704b1158d33d505b8a738d46f727f /chrome/app/nibs | |
| parent | 08338efa63dadfe9c830bcdd54643c8b70d1dbf1 (diff) | |
| download | chromium_src-e59a1c4503496f843391641dbb947043dec2a466.zip chromium_src-e59a1c4503496f843391641dbb947043dec2a466.tar.gz chromium_src-e59a1c4503496f843391641dbb947043dec2a466.tar.bz2 | |
AutoFill dialog UI polish. Based on feedback from thakis.
Change to AutoFillDialog.xib was window anchoring flags to better position dialog in different window sizes on first run.
> 1.) The initial position of the dialog is half off-screen on my 15'' MBP. It should probably be
> more on the left.
>
Done. Auto centering now.
> 2.) Furthermore, the dialog should autosave its position. See e.g.
> keyword_editor_cocoa_controller.mm on how to do this (the |if (g_browser_process...)| block in
> |initWithProfile| – it takes only a couple lines).
>
Done.
> 3.) When clicking "Add an address", I find it weird that the new address starts in the collapsed
> state. That makes it hard to see how to delete it again, and chances are that when I'm adding a
> new address I want to edit it immediately.
>
Done.
BUG=36441
TEST=see manual repro steps above.
Review URL: http://codereview.chromium.org/660130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40075 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app/nibs')
| -rw-r--r-- | chrome/app/nibs/AutoFillDialog.xib | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/app/nibs/AutoFillDialog.xib b/chrome/app/nibs/AutoFillDialog.xib index e4ab911..039a4b7 100644 --- a/chrome/app/nibs/AutoFillDialog.xib +++ b/chrome/app/nibs/AutoFillDialog.xib @@ -38,8 +38,8 @@ <object class="NSWindowTemplate" id="1005"> <int key="NSWindowStyleMask">9</int> <int key="NSWindowBacking">2</int> - <string key="NSWindowRect">{{990, 893}, {570, 544}}</string> - <int key="NSWTFlags">538968064</int> + <string key="NSWindowRect">{{1022, 661}, {570, 544}}</string> + <int key="NSWTFlags">544735232</int> <string key="NSWindowTitle">^IDS_AUTOFILL_DIALOG_TITLE</string> <string key="NSWindowClass">NSWindow</string> <nil key="NSViewClass"/> |