diff options
author | thomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-28 12:01:29 +0000 |
---|---|---|
committer | thomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-28 12:01:29 +0000 |
commit | 4de39f87c85a89046e2bbead1ddd4d6c85e1278c (patch) | |
tree | 41c862a438f14947f760c92edc9a70d0aa7215ce /chrome/app/policy | |
parent | fb3e985829bde90a71134801d773ad8e1407dda1 (diff) | |
download | chromium_src-4de39f87c85a89046e2bbead1ddd4d6c85e1278c.zip chromium_src-4de39f87c85a89046e2bbead1ddd4d6c85e1278c.tar.gz chromium_src-4de39f87c85a89046e2bbead1ddd4d6c85e1278c.tar.bz2 |
Standardize grit invokes
- Add two gypi files to src/build for the boilerplate added to targets and actions
- Update grit_info to also support the -E flag so it can share more of the grit build commandline
- switch over all but the webkit and webkit glue grd files to use the common support
BUG=22247
TEST=everything still localized correctly
Review URL: http://codereview.chromium.org/6705030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79548 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app/policy')
-rw-r--r-- | chrome/app/policy/policy_templates.gypi | 53 |
1 files changed, 9 insertions, 44 deletions
diff --git a/chrome/app/policy/policy_templates.gypi b/chrome/app/policy/policy_templates.gypi index 00927d8..4b9dd72 100644 --- a/chrome/app/policy/policy_templates.gypi +++ b/chrome/app/policy/policy_templates.gypi @@ -12,56 +12,24 @@ 'target_name': 'policy_templates', 'type': 'none', 'variables': { - 'grd_path': 'policy_templates.grd', - 'template_files': [ - '<!@(<(grit_info_cmd) --outputs \'<(grit_out_dir)\' <(grd_path))' - ], + 'grit_grd_file': 'policy_templates.grd', + 'grit_info_cmd': ['python', '<(DEPTH)/tools/grit/grit_info.py', + '<@(grit_defines)'], }, + 'includes': [ '../../../build/grit_target.gypi' ], 'actions': [ { 'action_name': 'policy_templates', - 'variables': { - 'conditions': [ - ['branding=="Chrome"', { - # TODO(mmoss) The .grd files look for _google_chrome, but - # for consistency they should look for GOOGLE_CHROME_BUILD - # like C++. - # Clean this up when Windows moves to gyp. - 'chrome_build': '_google_chrome', - }, { # else: branding!="Chrome" - 'chrome_build': '_chromium', - }], - ], - }, - 'inputs': [ - '<!@(<(grit_info_cmd) --inputs <(grd_path))', - ], - 'outputs': [ - '<@(template_files)' - ], - 'action': [ - '<@(grit_cmd)', - '-i', '<(grd_path)', 'build', - '-o', '<(grit_out_dir)', - '<@(grit_defines)', - ], - 'conditions': [ - ['OS == "mac"', { - 'action': ['-D', 'mac_bundle_id=<(mac_bundle_id)'], - }], - ], - 'message': 'Generating policy templates from <(grd_path)', + 'includes': [ '../../../build/grit_action.gypi' ], }, ], - 'direct_dependent_settings': { - 'include_dirs': [ - '<(grit_out_dir)', - ], - }, 'conditions': [ ['OS=="win"', { 'variables': { 'version_path': '<(grit_out_dir)/app/policy/VERSION', + 'template_files': [ + '<!@(<(grit_info_cmd) --outputs \'<(grit_out_dir)\' <(grit_grd_file))' + ], }, 'actions': [ { @@ -98,10 +66,7 @@ } ] }], - ['OS=="win"', { - 'dependencies': ['../build/win/system.gyp:cygwin'], - }], - ], + ], # conditions }, ], # 'targets' }], # OS=="win" or OS=="mac" or OS=="linux" |