diff options
author | jungshik@google.com <jungshik@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-15 19:16:10 +0000 |
---|---|---|
committer | jungshik@google.com <jungshik@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-15 19:16:10 +0000 |
commit | 3bd29d38ab1b03648ba9d3682ddc1d23c5cadad5 (patch) | |
tree | 20e24e86fa15207175dbcd1c0da23b31d980bfb2 /chrome/app/resources/locale_settings_pl.xtb | |
parent | 658b4fe27cae13bd99c0d8cb910d3d4ee16fea7c (diff) | |
download | chromium_src-3bd29d38ab1b03648ba9d3682ddc1d23c5cadad5.zip chromium_src-3bd29d38ab1b03648ba9d3682ddc1d23c5cadad5.tar.gz chromium_src-3bd29d38ab1b03648ba9d3682ddc1d23c5cadad5.tar.bz2 |
For some Indian locales, the automatic font fallback by Windows UI components leads to too tiny glyphs for UI strings. Therefore, this patch makes it possible to override the UI font family and UI font size localizable by adding two entries to locale_settings (IDS_UI_FONT_FAMILY and IDS_UI_FONT_SIZE_SCALER - percentile scale).
It's is also to fix a P1 bug for Chrome 2.0 final (so this patch needs to be merged back to the branch).
For most locales, the UI font family is set to 'default' and the UI font size scaler is set to 100, which indicates that the UI font (menu, message, etc) obtained from Windows will be used.
For ml and bn, it's set to the 'kartica' and 'vrinda' (the default Windows fonts for those scripts) and the scaler is set to 150 and 160 respectively. For Hindi and Telugu, only the font size scaler is set to 150.
When IDS_UI_FONT_FAMILY is 'default' and the scaler is 100, the behavior will remain the same. When it's not, their values are used to create ChromeFont (base and derived) and WindowsTitle font. In addition, menu will be drawn by 'owner' (to override the windows font) and the font for table view, tree and tooltip is also set to IDS_UI_FONT_FAMILY.
While working on this, I replaced all the instances of 'static ChromeFont' with 'static ChromeFont*' and initialized them in a lazy manner.
The whole approach is still a hack necessary due to the size issue with the default fonts for some Indic scripts on Windows. We'd not need this on Linux and Mac.
TEST=1. Run chrome with '--lang=bn' or '--lang=ml' and see UI strings are legible in menu, context menu, bookmark, bookmark manager, tooltips, and tab titles. With '--lang=hi' and '--lang=te', the difference is not dramatic but should be more readable. In other locales, it should remain the same.
2.UI test in en-US locale should pass.
3. Running UI tests under Purify should not have any new leak.
BUG=7319
Review URL: http://codereview.chromium.org/62064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13773 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app/resources/locale_settings_pl.xtb')
-rw-r--r-- | chrome/app/resources/locale_settings_pl.xtb | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/app/resources/locale_settings_pl.xtb b/chrome/app/resources/locale_settings_pl.xtb index 0f1e29d..39588ce 100644 --- a/chrome/app/resources/locale_settings_pl.xtb +++ b/chrome/app/resources/locale_settings_pl.xtb @@ -3,6 +3,8 @@ <translationbundle lang="pl"> <translation id="IDS_WEB_FONT_FAMILY">Arial</translation> <translation id="IDS_WEB_FONT_SIZE">84%</translation> +<translation id="IDS_UI_FONT_FAMILY">default</translation> +<translation id="IDS_UI_FONT_SIZE_SCALER">100</translation> <translation id="IDS_ACCEPT_LANGUAGES">pl-PL,pl,en-US,en</translation> <translation id="IDS_DEFAULT_ENCODING">ISO-8859-2</translation> <translation id="IDS_STANDARD_FONT_IS_SERIF">true</translation> |