diff options
| author | cpu@google.com <cpu@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-25 22:17:42 +0000 |
|---|---|---|
| committer | cpu@google.com <cpu@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-25 22:17:42 +0000 |
| commit | c9ed2dac1ab2d96894ecc1abd7bac9558346d893 (patch) | |
| tree | 34c35b3812a72d7b1a28f3c912bf69cfe1db8161 /chrome/app | |
| parent | 89fe216da236a9930cfab994a67e3110575e6e87 (diff) | |
| download | chromium_src-c9ed2dac1ab2d96894ecc1abd7bac9558346d893.zip chromium_src-c9ed2dac1ab2d96894ecc1abd7bac9558346d893.tar.gz chromium_src-c9ed2dac1ab2d96894ecc1abd7bac9558346d893.tar.bz2 | |
change a str pass by value. Words fail me to describe this CL better
- Yes it is silly
- Yes it bothers me every time I see it.
Review URL: http://codereview.chromium.org/27155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10388 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app')
| -rw-r--r-- | chrome/app/breakpad.cc | 2 | ||||
| -rw-r--r-- | chrome/app/breakpad.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/chrome/app/breakpad.cc b/chrome/app/breakpad.cc index 540127a..19071ac 100644 --- a/chrome/app/breakpad.cc +++ b/chrome/app/breakpad.cc @@ -239,7 +239,7 @@ void InitDefaultCrashCallback() { previous_filter = SetUnhandledExceptionFilter(ChromeExceptionFilter); } -void InitCrashReporter(std::wstring dll_path) { +void InitCrashReporter(const std::wstring& dll_path) { const CommandLine& command = *CommandLine::ForCurrentProcess(); if (!command.HasSwitch(switches::kDisableBreakpad)) { // Disable the message box for assertions. diff --git a/chrome/app/breakpad.h b/chrome/app/breakpad.h index 8250b4b..daa3d77 100644 --- a/chrome/app/breakpad.h +++ b/chrome/app/breakpad.h @@ -10,7 +10,7 @@ // Calls InitCrashReporterThread in it's own thread for the browser process // or directly for the plugin and renderer process. -void InitCrashReporter(std::wstring dll_path); +void InitCrashReporter(const std::wstring& dll_path); // Intercepts a crash but does not process it, just ask if we want to restart // the browser or not. |