diff options
author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-30 01:23:32 +0000 |
---|---|---|
committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-30 01:23:32 +0000 |
commit | 1979689363e58c9917d751d5134287d8616528e5 (patch) | |
tree | 6342d081e86670f1a05b07933888278d6e355759 /chrome/app | |
parent | 27d3571b99a7e69bedb8ac0282b981325906edc2 (diff) | |
download | chromium_src-1979689363e58c9917d751d5134287d8616528e5.zip chromium_src-1979689363e58c9917d751d5134287d8616528e5.tar.gz chromium_src-1979689363e58c9917d751d5134287d8616528e5.tar.bz2 |
Revert r46023: "Detect new instance of the browser when running in the background in persistent"
Broke the build.
Review URL: http://codereview.chromium.org/1718024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46025 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app')
-rw-r--r-- | chrome/app/chrome_exe_main.cc | 1 | ||||
-rw-r--r-- | chrome/app/chrome_exe_main_gtk.cc | 9 | ||||
-rw-r--r-- | chrome/app/client_util.cc | 15 | ||||
-rw-r--r-- | chrome/app/client_util.h | 4 |
4 files changed, 1 insertions, 28 deletions
diff --git a/chrome/app/chrome_exe_main.cc b/chrome/app/chrome_exe_main.cc index ed4c263..fdd2cac 100644 --- a/chrome/app/chrome_exe_main.cc +++ b/chrome/app/chrome_exe_main.cc @@ -44,7 +44,6 @@ int APIENTRY wWinMain(HINSTANCE instance, HINSTANCE, wchar_t*, int) { // Load and launch the chrome dll. *Everything* happens inside. MainDllLoader* loader = MakeMainDllLoader(); int rc = loader->Launch(instance, &sandbox_info); - loader->RelaunchChromeBrowserWithNewCommandLineIfNeeded(); delete loader; return rc; diff --git a/chrome/app/chrome_exe_main_gtk.cc b/chrome/app/chrome_exe_main_gtk.cc index 8b612c7..0ed9e15 100644 --- a/chrome/app/chrome_exe_main_gtk.cc +++ b/chrome/app/chrome_exe_main_gtk.cc @@ -4,7 +4,6 @@ #include "base/at_exit.h" #include "base/process_util.h" -#include "chrome/browser/first_run.h" // The entry point for all invocations of Chromium, browser and renderer. On // windows, this does nothing but load chrome.dll and invoke its entry point in @@ -45,11 +44,5 @@ int main(int argc, const char** argv) { // keep it. // base::AtExitManager exit_manager; - int return_code = ChromeMain(argc, argv); - - // Launch a new instance if we're shutting down because we detected an - // upgrade in the persistent mode. - Upgrade::RelaunchChromeBrowserWithNewCommandLineIfNeeded(); - - return return_code; + return ChromeMain(argc, argv); } diff --git a/chrome/app/client_util.cc b/chrome/app/client_util.cc index c822ec8..074b6c8 100644 --- a/chrome/app/client_util.cc +++ b/chrome/app/client_util.cc @@ -18,8 +18,6 @@ namespace { // The entry point signature of chrome.dll. typedef int (*DLL_MAIN)(HINSTANCE, sandbox::SandboxInterfaceInfo*, wchar_t*); -typedef void (*RelaunchChromeBrowserWithNewCommandLineIfNeededFunc)(); - // Not generic, we only handle strings up to 128 chars. bool ReadRegistryStr(HKEY key, const wchar_t* name, std::wstring* value) { BYTE out[128 * sizeof(wchar_t)]; @@ -198,19 +196,6 @@ int MainDllLoader::Launch(HINSTANCE instance, return OnBeforeExit(rc); } -void MainDllLoader::RelaunchChromeBrowserWithNewCommandLineIfNeeded() { - RelaunchChromeBrowserWithNewCommandLineIfNeededFunc relaunch_function = - reinterpret_cast<RelaunchChromeBrowserWithNewCommandLineIfNeededFunc>( - ::GetProcAddress(dll_, - "RelaunchChromeBrowserWithNewCommandLineIfNeeded")); - if (!relaunch_function) { - LOG(ERROR) << "Could not find exported function " - << "RelaunchChromeBrowserWithNewCommandLineIfNeeded"; - } else { - relaunch_function(); - } -} - //============================================================================= class ChromeDllLoader : public MainDllLoader { diff --git a/chrome/app/client_util.h b/chrome/app/client_util.h index 8b6c154f..a391be0 100644 --- a/chrome/app/client_util.h +++ b/chrome/app/client_util.h @@ -30,10 +30,6 @@ class MainDllLoader { // upon termination. int Launch(HINSTANCE instance, sandbox::SandboxInterfaceInfo* sbox_info); - // Launches a new instance of the browser if the current instance in - // persistent mode an upgrade is detected. - void RelaunchChromeBrowserWithNewCommandLineIfNeeded(); - // Derived classes must return the relative registry path that holds the // most current version of chrome.dll. virtual std::wstring GetRegistryPath() = 0; |