diff options
| author | arv@chromium.org <arv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-12 21:08:43 +0000 |
|---|---|---|
| committer | arv@chromium.org <arv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-12 21:08:43 +0000 |
| commit | 4c68ef64b5246de874c28dac745038ec713884c5 (patch) | |
| tree | d3590f927d144be642500b2099aff96dd080dbb5 /chrome/app | |
| parent | 0e9981e59506eddcbb66a23cf11639e983553e61 (diff) | |
| download | chromium_src-4c68ef64b5246de874c28dac745038ec713884c5.zip chromium_src-4c68ef64b5246de874c28dac745038ec713884c5.tar.gz chromium_src-4c68ef64b5246de874c28dac745038ec713884c5.tar.bz2 | |
NTP: Hide "Make this my home page" after setting the home page.
This also fixes an l10n issue where the string was hard coded in English.
Instead of using the tips infrastructure, after setting the home page we send
an ack to the NTP and show a notification. In this way the user will see the
notification even if they have hidden the tips.
Added a ui test that clicks on the link and checks the state of the UI
afterwards.
BUG=25101
TEST=Set your home page to non NTP. Go the the NTP by opening a new tab. Click
on the link "Make this my home page" at the bottom. You should see a banner at
the top. Pressing Alt-Home should now go to the NTP.
Review URL: http://codereview.chromium.org/392005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31823 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app')
| -rw-r--r-- | chrome/app/generated_resources.grd | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd index dae19c5..0945b04 100644 --- a/chrome/app/generated_resources.grd +++ b/chrome/app/generated_resources.grd @@ -4783,6 +4783,14 @@ Keep your key file in a safe place. You will need it to create new versions of y desc="Menu item text used to show or hide the bookmark sync status."> Bookmark sync </message> + <message name="IDS_NEW_TAB_HOME_PAGE_SET_NOTIFICATION" + desc="Notification text to show after the user has made the NTP his/her home page."> + Welcome to your home page! + </message> + <message name="IDS_NEW_TAB_HOME_PAGE_HIDE_NOTIFICATION" + desc="The action text to show as the close link for the notification shown after the user has set his/her home page."> + Close + </message> <!-- New tab page web clips. These are not in use yet --> <message name="IDS_NEW_TAB_WEB_CLIPS_WEB_CLIPS" |