diff options
| author | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-29 23:38:06 +0000 |
|---|---|---|
| committer | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-29 23:38:06 +0000 |
| commit | 7f856bee73ffdccdbbbbbab4cb79185290d38359 (patch) | |
| tree | a837328e08a113abdc70b2fc0ae2f2a4a3f804eb /chrome/app | |
| parent | 281fe14063dd8fb81cea102f5abb7b82f407c3d1 (diff) | |
| download | chromium_src-7f856bee73ffdccdbbbbbab4cb79185290d38359.zip chromium_src-7f856bee73ffdccdbbbbbab4cb79185290d38359.tar.gz chromium_src-7f856bee73ffdccdbbbbbab4cb79185290d38359.tar.bz2 | |
First cut at the bookmark manager. There are still a fair number of
rough edges, but I'm at a good point where I want to land what I
have. Here's what is left:
. Flicker on show, likely the result of restoring window placement.
. tree flickers when dragging splitter.
. table/tree need to autoscroll when drop cursor held at bottom of view.
. prompts for deleting.
. When you move an item the table snaps to the top, this is because
I'm sending out model changed. need a better notification.
. Operations in menu to add need to change selection.
. Remember split location.
I would have preferred to split this up into a couple of reviews, but
everything is intertwined now. Sorry.
BUG=674
TEST=don't test the bookmark manager yet, but make sure bookmark bar
still works.
Review URL: http://codereview.chromium.org/8197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4191 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app')
| -rw-r--r-- | chrome/app/chrome_dll.rc | 1 | ||||
| -rw-r--r-- | chrome/app/chrome_dll_resource.h | 1 | ||||
| -rw-r--r-- | chrome/app/locales/locale_settings.h | 5 | ||||
| -rw-r--r-- | chrome/app/resources/locale_settings_en-US.rc | 2 |
4 files changed, 9 insertions, 0 deletions
diff --git a/chrome/app/chrome_dll.rc b/chrome/app/chrome_dll.rc index b9d5486..7c5665a 100644 --- a/chrome/app/chrome_dll.rc +++ b/chrome/app/chrome_dll.rc @@ -89,6 +89,7 @@ BEGIN "8", IDC_SELECT_TAB_7, VIRTKEY, CONTROL VK_NUMPAD8, IDC_SELECT_TAB_7, VIRTKEY, CONTROL "B", IDC_SHOW_BOOKMARKS_BAR, VIRTKEY, CONTROL + "B", IDC_SHOW_BOOKMARK_MANAGER, VIRTKEY, CONTROL, SHIFT "J", IDC_SHOW_DOWNLOADS, VIRTKEY, CONTROL "H", IDC_SHOW_HISTORY, VIRTKEY, CONTROL "D", IDC_STAR, VIRTKEY, CONTROL diff --git a/chrome/app/chrome_dll_resource.h b/chrome/app/chrome_dll_resource.h index 833f071..61a135c 100644 --- a/chrome/app/chrome_dll_resource.h +++ b/chrome/app/chrome_dll_resource.h @@ -149,6 +149,7 @@ #define IDC_SHOW_BOOKMARKS_BAR 32946 // Free space 32947 - 32950 #define IDR_CRASHED_PLUGIN 32951 +#define IDC_SHOW_BOOKMARK_MANAGER 32952 // Next default values for new objects // diff --git a/chrome/app/locales/locale_settings.h b/chrome/app/locales/locale_settings.h index 855536a..d5198ab 100644 --- a/chrome/app/locales/locale_settings.h +++ b/chrome/app/locales/locale_settings.h @@ -165,3 +165,8 @@ // The HTML for the about:terms page #define IDR_TERMS_HTML 1061 + +// The width and height of the bookmark manager in characters and lines +// (See above). +#define IDS_BOOKMARK_MANAGER_DIALOG_WIDTH_CHARS 1062 +#define IDS_BOOKMARK_MANAGER_DIALOG_HEIGHT_LINES 1063 diff --git a/chrome/app/resources/locale_settings_en-US.rc b/chrome/app/resources/locale_settings_en-US.rc index 59f7222..19606a6 100644 --- a/chrome/app/resources/locale_settings_en-US.rc +++ b/chrome/app/resources/locale_settings_en-US.rc @@ -60,6 +60,8 @@ BEGIN IDS_WELCOME_PAGE_URL "http://tools.google.com/chrome/intl/en-US/welcome.html" IDS_LEARN_MORE_INCOGNITO_URL "http://www.google.com/support/chrome/bin/answer.py?answer=95464&hl=en-US" IDS_LEARN_MORE_HELPMAKECHROMEBETTER_URL "http://www.google.com/support/chrome/bin/answer.py?answer=96817&hl=en-US" + IDS_BOOKMARK_MANAGER_DIALOG_WIDTH_CHARS "150" + IDS_BOOKMARK_MANAGER_DIALOG_HEIGHT_LINES "40" END #if defined(GOOGLE_CHROME_BUILD) |