diff options
| author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-09 04:45:07 +0000 |
|---|---|---|
| committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-09 04:45:07 +0000 |
| commit | 152494e06591140bbf5003bba82cafa6f34962ec (patch) | |
| tree | f55043335e4caed020668c25423bb0ec586b2802 /chrome/app | |
| parent | 1b9af295f86b846582f96277bdba05d98bc3d2f4 (diff) | |
| download | chromium_src-152494e06591140bbf5003bba82cafa6f34962ec.zip chromium_src-152494e06591140bbf5003bba82cafa6f34962ec.tar.gz chromium_src-152494e06591140bbf5003bba82cafa6f34962ec.tar.bz2 | |
- Fix janklist issue #1: "there is a pixel line below the main
toolbar. The main toolbar should blend in with the bookmark bar when
it's open"
- Fix janklist issue #2: "It's way too tall - the distance from the
bottom of the bar to a bookmark button bottom edge should be the
same as the distance from the omnibox to the bookmark button top
edge (this will probably mean that the bar has to overlap the
toolbar)."
- Fix janklist issue #4 (first part): "the bookmark bar bookmark buttons
have a frame around them ... "
- Fix janklist issue #9: "the show/hide animation is very janky... I see
a dark gray area behind". Even with animators the grey is gone, but
animators are disabled for now due to races.
- Fix unlisted jank related to 9: don't use animator when opening bar on
launch.
- Also chipped away on unit tests.
TEST=Launch with bookmark bar both open and closed. Make sure OK on launch.
In each case open and close a few times fast.
Repeat with multiple windows open.
Sanity check jank descriptions listed above are fixed.
BUG=crbug.com/14139, crbug.com/8381, crbug.com/14724
Review URL: http://codereview.chromium.org/149308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20244 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app')
| -rw-r--r-- | chrome/app/nibs/en.lproj/Toolbar.xib | 87 |
1 files changed, 80 insertions, 7 deletions
diff --git a/chrome/app/nibs/en.lproj/Toolbar.xib b/chrome/app/nibs/en.lproj/Toolbar.xib index 94e1e64..702bc9e 100644 --- a/chrome/app/nibs/en.lproj/Toolbar.xib +++ b/chrome/app/nibs/en.lproj/Toolbar.xib @@ -2,14 +2,14 @@ <archive type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="7.03"> <data> <int key="IBDocument.SystemTarget">1050</int> - <string key="IBDocument.SystemVersion">9F33</string> + <string key="IBDocument.SystemVersion">9J61</string> <string key="IBDocument.InterfaceBuilderVersion">677</string> - <string key="IBDocument.AppKitVersion">949.34</string> - <string key="IBDocument.HIToolboxVersion">352.00</string> + <string key="IBDocument.AppKitVersion">949.46</string> + <string key="IBDocument.HIToolboxVersion">353.00</string> <object class="NSMutableArray" key="IBDocument.EditedObjectIDs"> <bool key="EncodedWithXMLCoder">YES</bool> - <integer value="1"/> <integer value="48"/> + <integer value="119"/> </object> <object class="NSArray" key="IBDocument.PluginDependencies"> <bool key="EncodedWithXMLCoder">YES</bool> @@ -286,6 +286,13 @@ <int key="NSPeriodicInterval">75</int> </object> </object> + <object class="NSCustomView" id="1060691879"> + <reference key="NSNextResponder" ref="928520650"/> + <int key="NSvFlags">-2147483358</int> + <string key="NSFrameSize">{607, 20}</string> + <reference key="NSSuperview" ref="928520650"/> + <string key="NSClassName">BookmarkBarView</string> + </object> </object> <string key="NSFrameSize">{607, 38}</string> <reference key="NSSuperview"/> @@ -1039,6 +1046,14 @@ </object> <int key="connectionID">118</int> </object> + <object class="IBConnectionRecord"> + <object class="IBOutletConnection" key="connection"> + <string key="label">bookmarkBarView_</string> + <reference key="source" ref="1001"/> + <reference key="destination" ref="1060691879"/> + </object> + <int key="connectionID">120</int> + </object> </object> <object class="IBMutableOrderedSet" key="objectRecords"> <object class="NSArray" key="orderedObjects"> @@ -1083,6 +1098,7 @@ <reference ref="559273956"/> <reference ref="571076484"/> <reference ref="602421009"/> + <reference ref="1060691879"/> </object> <reference key="parent" ref="1002"/> </object> @@ -1492,6 +1508,11 @@ <reference key="object" ref="510846575"/> <reference key="parent" ref="558188039"/> </object> + <object class="IBObjectRecord"> + <int key="objectID">119</int> + <reference key="object" ref="1060691879"/> + <reference key="parent" ref="928520650"/> + </object> </object> </object> <object class="NSMutableDictionary" key="flattenedProperties"> @@ -1513,6 +1534,7 @@ <string>105.IBPluginDependency</string> <string>106.IBPluginDependency</string> <string>107.IBPluginDependency</string> + <string>119.IBPluginDependency</string> <string>12.CustomClassName</string> <string>12.IBPluginDependency</string> <string>13.CustomClassName</string> @@ -1584,7 +1606,7 @@ <string>com.apple.InterfaceBuilder.CocoaPlugin</string> <string>com.apple.InterfaceBuilder.CocoaPlugin</string> <string>com.apple.InterfaceBuilder.CocoaPlugin</string> - <string>{{528, 657}, {607, 38}}</string> + <string>{{525, 688}, {607, 38}}</string> <string>com.apple.InterfaceBuilder.CocoaPlugin</string> <string>ToolbarButtonCell</string> <string>com.apple.InterfaceBuilder.CocoaPlugin</string> @@ -1596,6 +1618,7 @@ <string>com.apple.InterfaceBuilder.CocoaPlugin</string> <string>com.apple.InterfaceBuilder.CocoaPlugin</string> <string>com.apple.InterfaceBuilder.CocoaPlugin</string> + <string>com.apple.InterfaceBuilder.CocoaPlugin</string> <string>ToolbarButtonCell</string> <string>com.apple.InterfaceBuilder.CocoaPlugin</string> <string>LocationBarCell</string> @@ -1621,7 +1644,7 @@ <string>com.apple.InterfaceBuilder.CocoaPlugin</string> <string>com.apple.InterfaceBuilder.CocoaPlugin</string> <string>com.apple.InterfaceBuilder.CocoaPlugin</string> - <string>{{347, 753}, {248, 263}}</string> + <string>{{571, 1058}, {248, 263}}</string> <string>com.apple.InterfaceBuilder.CocoaPlugin</string> <string>com.apple.InterfaceBuilder.CocoaPlugin</string> <string>com.apple.InterfaceBuilder.CocoaPlugin</string> @@ -1683,7 +1706,7 @@ </object> </object> <nil key="sourceID"/> - <int key="maxID">118</int> + <int key="maxID">120</int> </object> <object class="IBClassDescriber" key="IBDocument.Classes"> <object class="NSMutableArray" key="referencedPartialClassDescriptions"> @@ -1733,6 +1756,14 @@ </object> </object> <object class="IBPartialClassDescription"> + <string key="className">BookmarkBarView</string> + <string key="superclassName">BackgroundGradientView</string> + <object class="IBClassDescriptionSource" key="sourceIdentifier"> + <string key="majorKey">IBProjectSource</string> + <string key="minorKey">browser/cocoa/bookmark_bar_view.h</string> + </object> + </object> + <object class="IBPartialClassDescription"> <string key="className">FirstResponder</string> <string key="superclassName">NSObject</string> <object class="NSMutableDictionary" key="actions"> @@ -1820,6 +1851,44 @@ </object> </object> <object class="IBPartialClassDescription"> + <string key="className">TabController</string> + <string key="superclassName">NSViewController</string> + <object class="NSMutableDictionary" key="actions"> + <bool key="EncodedWithXMLCoder">YES</bool> + <object class="NSMutableArray" key="dict.sortedKeys"> + <bool key="EncodedWithXMLCoder">YES</bool> + <string>closeTab:</string> + <string>commandDispatch:</string> + </object> + <object class="NSMutableArray" key="dict.values"> + <bool key="EncodedWithXMLCoder">YES</bool> + <string>id</string> + <string>id</string> + </object> + </object> + <object class="NSMutableDictionary" key="outlets"> + <bool key="EncodedWithXMLCoder">YES</bool> + <object class="NSMutableArray" key="dict.sortedKeys"> + <bool key="EncodedWithXMLCoder">YES</bool> + <string>backgroundButton_</string> + <string>contextMenu_</string> + <string>iconView_</string> + <string>target_</string> + </object> + <object class="NSMutableArray" key="dict.values"> + <bool key="EncodedWithXMLCoder">YES</bool> + <string>NSButton</string> + <string>NSMenu</string> + <string>NSView</string> + <string>id</string> + </object> + </object> + <object class="IBClassDescriptionSource" key="sourceIdentifier"> + <string key="majorKey">IBProjectSource</string> + <string key="minorKey">browser/cocoa/tab_controller.h</string> + </object> + </object> + <object class="IBPartialClassDescription"> <string key="className">ToolbarButtonCell</string> <string key="superclassName">GradientButtonCell</string> <object class="IBClassDescriptionSource" key="sourceIdentifier"> @@ -1856,6 +1925,8 @@ <object class="NSMutableArray" key="dict.sortedKeys"> <bool key="EncodedWithXMLCoder">YES</bool> <string>backButton_</string> + <string>bookmarkBarDelegate_</string> + <string>bookmarkBarView_</string> <string>forwardButton_</string> <string>goButton_</string> <string>homeButton_</string> @@ -1870,6 +1941,8 @@ <object class="NSMutableArray" key="dict.values"> <bool key="EncodedWithXMLCoder">YES</bool> <string>NSButton</string> + <string>id</string> + <string>BookmarkBarView</string> <string>NSButton</string> <string>NSButton</string> <string>NSButton</string> |