summaryrefslogtreecommitdiffstats
path: root/chrome/app
diff options
context:
space:
mode:
authorcpu@google.com <cpu@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-08-01 23:30:11 +0000
committercpu@google.com <cpu@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-08-01 23:30:11 +0000
commitc0d3966ae1febdbc51a4527c6914c29ba4ccc4a2 (patch)
tree1138b92347f6e8399efbeaef8d8149ab366e17d2 /chrome/app
parentbc5e667d6f36f04f3b4376a420a87e6d5bf01043 (diff)
downloadchromium_src-c0d3966ae1febdbc51a4527c6914c29ba4ccc4a2.zip
chromium_src-c0d3966ae1febdbc51a4527c6914c29ba4ccc4a2.tar.gz
chromium_src-c0d3966ae1febdbc51a4527c6914c29ba4ccc4a2.tar.bz2
One more time, try to land the change that removes FreeLibrary(chrome_dll). Our code is not well prepared to handle this case.
BUG=1286612 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app')
-rw-r--r--chrome/app/google_update_client.cc4
1 files changed, 4 insertions, 0 deletions
diff --git a/chrome/app/google_update_client.cc b/chrome/app/google_update_client.cc
index c8bba6d..a8cd8af 100644
--- a/chrome/app/google_update_client.cc
+++ b/chrome/app/google_update_client.cc
@@ -199,7 +199,11 @@ bool GoogleUpdateClient::Launch(HINSTANCE instance, HINSTANCE prev_instance,
}
did_launch = true;
}
+#ifdef PURIFY
+ // We should never unload the dll. There is only risk and no gain from
+ // doing so. The singleton dtors have been already run by AtExitManager.
::FreeLibrary(dll_handle);
+#endif
} else {
unsigned long err = GetLastError();
if (err) {