diff options
| author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-05 21:49:26 +0000 |
|---|---|---|
| committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-05 21:49:26 +0000 |
| commit | 7a4f563b87e5319d2b7892da301b4aed36160f34 (patch) | |
| tree | 22ed0b456fb089316b18afe8950a340703be0d8a /chrome/app | |
| parent | 9ec8a8ce8b2cb0c29387ddccce7fb0fb356e0b2c (diff) | |
| download | chromium_src-7a4f563b87e5319d2b7892da301b4aed36160f34.zip chromium_src-7a4f563b87e5319d2b7892da301b4aed36160f34.tar.gz chromium_src-7a4f563b87e5319d2b7892da301b4aed36160f34.tar.bz2 | |
GTK: Fancy html5 draggy stuff.
Also, don't crash in release mode when the tab contents is deleted during a drag.
1) Source side: when the tab contents is going down, abort the current drag (if any). Initiate drags on a GtkInvisible (matching firefox, among other programs I assume). This lets us give up ownership of the drag widget and let the drag unwind.
2) Destination side: make a seemingly harmless GTK assert point to a crbug bug. This warrants further investigation.
BUG=16249
TEST=drag around ntp thumbnails
BUG=18557
In release mode, you should be able to do all the following without crashing or getting any asserts besides the two mentioned in 18557
TEST=drag something from gedit over a tab that closes
TEST=drag something from the render view over a tab that closes
TEST=drag something from the render view off of the browser from within a tab that closes
TEST=repeat all the above with a tab that is being swapped out according to the repro steps in bug 16073
Review URL: http://codereview.chromium.org/159889
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22542 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app')
| -rw-r--r-- | chrome/app/chrome_dll_main.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/app/chrome_dll_main.cc b/chrome/app/chrome_dll_main.cc index 7576dfd..c17dcfe 100644 --- a/chrome/app/chrome_dll_main.cc +++ b/chrome/app/chrome_dll_main.cc @@ -190,6 +190,8 @@ static void GLibLogHandler(const gchar* log_domain, strstr(message, "Theme directory") || strstr(message, "theme pixmap")) { LOG(ERROR) << "GTK theme error: " << message; + } else if (strstr(message, "gtk_drag_dest_leave: assertion")) { + LOG(ERROR) << "Drag destination deleted: http://crbug.com/18557"; } else { #ifdef NDEBUG LOG(ERROR) << log_domain << ": " << message; |