summaryrefslogtreecommitdiffstats
path: root/chrome/browser/BUILD.gn
diff options
context:
space:
mode:
authorteravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-07-24 23:58:56 +0000
committerteravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-07-24 23:58:56 +0000
commit1bb1a60006e39d853f1cefc21ddb56b7079a0ff0 (patch)
tree293e4f1006281b353be4838edeedb57e725b755c /chrome/browser/BUILD.gn
parent86f6571e3be3b88510d306011e50f74b0867fa0f (diff)
downloadchromium_src-1bb1a60006e39d853f1cefc21ddb56b7079a0ff0.zip
chromium_src-1bb1a60006e39d853f1cefc21ddb56b7079a0ff0.tar.gz
chromium_src-1bb1a60006e39d853f1cefc21ddb56b7079a0ff0.tar.bz2
Pepper: Remove LOAD_MODULE SRPC call in SFI mode.
This change puts nexe information in the parameters for starting a NaCl plugin instead of sending that information over SRPC. This may remove the need for that IPC round trip entirely; perhaps we could report load failure as part of the RPCs for starting sel_ldr or performing StartModule(). nacl_defines.gypi as added as a dependency in components/components_tests.gyp because nacl_process_host.h now includes "native_client/src/public/nacl_file_info.h", which requires nacl_defines. BUG=333950 R=bbudge@chromium.org, brettw@chromium.org, hidehiko@chromium.org, jschuh@chromium.org, mseaborn@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285028 Review URL: https://codereview.chromium.org/332463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285418 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/BUILD.gn')
-rw-r--r--chrome/browser/BUILD.gn4
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 6da60fb..42c994b 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -5,6 +5,7 @@
import("//build/config/crypto.gni")
import("//build/config/features.gni")
import("//build/config/ui.gni")
+import("//native_client/build/config/nacl_defines.gni")
import("//tools/grit/grit_rule.gni")
about_credits_file = "$target_gen_dir/about_credits.html"
@@ -128,8 +129,7 @@ static_library("browser") {
# # chrome/browser/metrics/variations/generate_resources_map.py
# '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/metrics/variations/generated_resources_map.cc',
- # TODO(GYP) Also add these nacl_defines to direct dependents.
- #defines = nacl_defines
+ defines = nacl_defines
# TODO(GYP) remove this when the real webrtc target is used below.
configs += [ "//content:webrtc_stub_config" ]