diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-11 05:41:40 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-11 05:41:40 +0000 |
| commit | 99907365ccdfb821ab0c34e36dadcb26ce25f20e (patch) | |
| tree | 8676bbe1bfebcf35c0f71d31b06b2c9f1e2afb6f /chrome/browser/DEPS | |
| parent | 57b8bb357db85d85157c3a87f0b87383343867d8 (diff) | |
| download | chromium_src-99907365ccdfb821ab0c34e36dadcb26ce25f20e.zip chromium_src-99907365ccdfb821ab0c34e36dadcb26ce25f20e.tar.gz chromium_src-99907365ccdfb821ab0c34e36dadcb26ce25f20e.tar.bz2 | |
Move creation and ownership of ResourceDispatcherHost and PluginService to content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117078
Review URL: http://codereview.chromium.org/9150016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117171 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/DEPS')
| -rw-r--r-- | chrome/browser/DEPS | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/browser/DEPS b/chrome/browser/DEPS index eb5d1e0..109c05c 100644 --- a/chrome/browser/DEPS +++ b/chrome/browser/DEPS @@ -29,6 +29,9 @@ include_rules = [ # TODO(jam): this needs to be removed, and only use content/public. BUG=98716 "+content/browser", + "-content/browser/download/download_manager_impl.h", + "-content/browser/download/download_resource_handler.h", + "-content/browser/download/save_file_manager.h", "-content/browser/notification_service_impl.h", "-content/browser/tab_contents/navigation_controller_impl.h", "-content/browser/tab_contents/navigation_entry_impl.h", |