diff options
| author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-25 14:22:34 +0000 |
|---|---|---|
| committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-25 14:22:34 +0000 |
| commit | b9fc13815c3476c751c6ca0f4b0f518bc8b736d3 (patch) | |
| tree | fdb991606b3ec6363f306485c3fd7a90dcbe11d8 /chrome/browser/DEPS | |
| parent | 1736e7f6c3f80f53254fe55afb35d207d283033d (diff) | |
| download | chromium_src-b9fc13815c3476c751c6ca0f4b0f518bc8b736d3.zip chromium_src-b9fc13815c3476c751c6ca0f4b0f518bc8b736d3.tar.gz chromium_src-b9fc13815c3476c751c6ca0f4b0f518bc8b736d3.tar.bz2 | |
Reduce chrome/ dependencies on platform-specific RenderWidgetHostView implementations.
Various dependencies on the GTK version remain, as does a single,
probably easy-to-remove dependency on the Mac implementation.
Did this primarily as follows:
a) Enforce the intent, that RenderWidgetHostView instances are created
via factory function.
b) Migrated a couple of methods to the interface, skipping
implementation for platforms where not needed.
c) Added InitAsChild, with parent view parameter, to the interface so
that Windows initialization can go through interface. Incidentally,
this fixes bug 102450. As noted in the bug, the approach of passing a
parent view pointer is somewhat ugly as it isn't needed by all
platform-specific implementations, but I think it is acceptable.
TBR=owners (interface change LGTMed by owner, rest is trivial updates)
BUG=98716,102450
Review URL: https://chromiumcodereview.appspot.com/9281003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119062 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/DEPS')
| -rw-r--r-- | chrome/browser/DEPS | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/DEPS b/chrome/browser/DEPS index fae60ab..10d70d2 100644 --- a/chrome/browser/DEPS +++ b/chrome/browser/DEPS @@ -101,11 +101,8 @@ include_rules = [ "+content/browser/renderer_host/render_view_host_factory.h", "+content/browser/renderer_host/render_widget_host.h", "+content/browser/renderer_host/render_widget_host_view.h", - "+content/browser/renderer_host/render_widget_host_view_aura.h", "+content/browser/renderer_host/render_widget_host_view_gtk.h", - "+content/browser/renderer_host/render_widget_host_view_mac.h", "+content/browser/renderer_host/render_widget_host_view_mac_delegate.h", - "+content/browser/renderer_host/render_widget_host_view_win.h", "+content/browser/renderer_host/resource_dispatcher_host.h", "+content/browser/renderer_host/resource_dispatcher_host_request_info.h", "+content/browser/renderer_host/resource_handler.h", |