diff options
| author | rdevlin.cronin@chromium.org <rdevlin.cronin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-29 00:52:56 +0000 |
|---|---|---|
| committer | rdevlin.cronin@chromium.org <rdevlin.cronin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-29 00:52:56 +0000 |
| commit | dccba4f812f5662655a441cedc58ef51d168911b (patch) | |
| tree | ac2dbf2a6abac7be140c6c8cf30458d8094f3893 /chrome/browser/accessibility | |
| parent | dfabeb5570a8a2ebdb19f1ae36959b9dd48004e9 (diff) | |
| download | chromium_src-dccba4f812f5662655a441cedc58ef51d168911b.zip chromium_src-dccba4f812f5662655a441cedc58ef51d168911b.tar.gz chromium_src-dccba4f812f5662655a441cedc58ef51d168911b.tar.bz2 | |
Cleanup extension_service.h
If the Broken Window Theory holds true, then ExtensionService will never be
cleaned up (and will, in fact, degrade faster than we can fix it) if it looks
like it's messy. So, let's clean house!
- Group overriden methods together, say what they override.
- Move all comments to the original method declaration (i.e., if it's overriden
from ExtensionServiceInterface, comment there).
- Move accessors together.
- Move for_test methods together.
- Move methods which are not used publicly into private:.
- Move simple getters/setters from the .cc to the .h.
- Remove FRIEND_TESTs that should not be there.
- Remove unneeded forward class declarations.
- Remove unneeded includes.*
*This one led to a BUNCH of fixes in other files, which relied on the
transitive includes of extension_service.h. Sorry for the noise.
BUG=351891
TBR=jochen@chromium.org (for every header file change - they're only fixing transitive includes)
Review URL: https://codereview.chromium.org/296073003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273424 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/accessibility')
| -rw-r--r-- | chrome/browser/accessibility/accessibility_extension_api.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/accessibility/accessibility_extension_api.cc b/chrome/browser/accessibility/accessibility_extension_api.cc index 829e49a..a96bacb 100644 --- a/chrome/browser/accessibility/accessibility_extension_api.cc +++ b/chrome/browser/accessibility/accessibility_extension_api.cc @@ -14,6 +14,7 @@ #include "chrome/browser/infobars/infobar_service.h" #include "chrome/browser/profiles/profile.h" #include "chrome/common/extensions/api/accessibility_private.h" +#include "chrome/common/extensions/extension_constants.h" #include "components/infobars/core/confirm_infobar_delegate.h" #include "components/infobars/core/infobar.h" #include "content/public/browser/browser_accessibility_state.h" |