diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-15 07:35:37 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-15 07:35:37 +0000 |
| commit | 79457797443d45463b92abcda0124706bdf1aff5 (patch) | |
| tree | 83c22707ecc9649686be8d5bb5bd74913c4520d8 /chrome/browser/app_controller_mac_unittest.mm | |
| parent | af980796c6c9df7bd06210397ffa5dad155ebf66 (diff) | |
| download | chromium_src-79457797443d45463b92abcda0124706bdf1aff5.zip chromium_src-79457797443d45463b92abcda0124706bdf1aff5.tar.gz chromium_src-79457797443d45463b92abcda0124706bdf1aff5.tar.bz2 | |
GTTF: Use a fresh TestingBrowserProcess for each test, part #1
This is going to be done in multiple steps,
because lots of tests depend on global TestingBrowserProcess.
However, the current solution is very error-prone,
and may lead to state being carried from one test
to another (via NotificationService), resulting in crashes.
In theory the ScopedTestingBrowserProcess could be made
empty for now, but re-initializing g_browser_process inside it
has two benefits:
1) It verifies that changing g_browser_process actually works.
2) It protects at least a subset of tests from carrying state.
BUG=61062
TEST=unit_tests, possibly more
Review URL: http://codereview.chromium.org/6478005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74926 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/app_controller_mac_unittest.mm')
| -rw-r--r-- | chrome/browser/app_controller_mac_unittest.mm | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/browser/app_controller_mac_unittest.mm b/chrome/browser/app_controller_mac_unittest.mm index 88e8de3..1ea2b38 100644 --- a/chrome/browser/app_controller_mac_unittest.mm +++ b/chrome/browser/app_controller_mac_unittest.mm @@ -7,9 +7,12 @@ #include "base/scoped_nsobject.h" #include "chrome/app/chrome_command_ids.h" #import "chrome/browser/app_controller_mac.h" +#include "chrome/test/testing_browser_process.h" #include "testing/platform_test.h" class AppControllerTest : public PlatformTest { + private: + ScopedTestingBrowserProcess browser_process_; }; TEST_F(AppControllerTest, DockMenu) { |