diff options
| author | fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-09 20:58:41 +0000 |
|---|---|---|
| committer | fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-09 20:58:41 +0000 |
| commit | fa4d91939c2e7df3e1667dfe2e01f61719543eb0 (patch) | |
| tree | 8f8102c283ea573acd2d8afa8f3c828f659d95f5 /chrome/browser/apps/web_view_interactive_browsertest.cc | |
| parent | 138f97e92ef1b23b7788616605a74e1840cf44d9 (diff) | |
| download | chromium_src-fa4d91939c2e7df3e1667dfe2e01f61719543eb0.zip chromium_src-fa4d91939c2e7df3e1667dfe2e01f61719543eb0.tar.gz chromium_src-fa4d91939c2e7df3e1667dfe2e01f61719543eb0.tar.bz2 | |
<webview>: Cleanup WebRequest event listeners when embedder destroyed
<webivew> WebRequest event listeners should survive reparenting of the <webview> within the same embedder WebContents. Currently, event listeners are lost when the <webview> is removed from the DOM. This CL solves this problem.
Note that there is still a problem where custom elements break if the original page that created the element is closed. I have written a test that exercises this problem and I've left the test disabled until we fix the problem.
BUG=281551
Test=WebViewTest.Shim_TestWebRequestListenerSurvivesReparenting
Review URL: https://chromiumcodereview.appspot.com/23514016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222090 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/apps/web_view_interactive_browsertest.cc')
| -rw-r--r-- | chrome/browser/apps/web_view_interactive_browsertest.cc | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/chrome/browser/apps/web_view_interactive_browsertest.cc b/chrome/browser/apps/web_view_interactive_browsertest.cc index 3bb2aa5..7620481 100644 --- a/chrome/browser/apps/web_view_interactive_browsertest.cc +++ b/chrome/browser/apps/web_view_interactive_browsertest.cc @@ -580,6 +580,16 @@ IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest, "web_view/newwindow"); } +// A custom elements bug needs to be addressed to enable this test: +// See http://crbug.com/282477 for more information. +IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest, + DISABLED_NewWindow_WebRequestCloseWindow) { + TestHelper("testNewWindowWebRequestCloseWindow", + "DoneNewWindowTest.PASSED", + "DoneNewWindowTest.FAILED", + "web_view/newwindow"); +} + IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest, ExecuteCode) { ASSERT_TRUE(StartEmbeddedTestServer()); // For serving guest pages. ASSERT_TRUE(RunPlatformAppTestWithArg( |