diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-03 23:07:35 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-03 23:07:35 +0000 |
| commit | 052212838598dff1ae487e654016da0771b9d975 (patch) | |
| tree | 21bbec60dec8c7e316a0e99ea9f387ba2e99075e /chrome/browser/autocomplete/autocomplete.h | |
| parent | 3828a755146e0102b934281129fdd6425ca19a0f (diff) | |
| download | chromium_src-052212838598dff1ae487e654016da0771b9d975.zip chromium_src-052212838598dff1ae487e654016da0771b9d975.tar.gz chromium_src-052212838598dff1ae487e654016da0771b9d975.tar.bz2 | |
Fix crash due to AutocompletePopup trying to draw the old results when they were no longer available.I introduced this regression when moving |result_| to the AutocompleteController; the specific problem was the "result_.CopyFrom(latest_result_);" line I added when handling the synchronous messages being available. This was done so the popup could get at the new results to update the edit with them.Instead, go back to the old method (of not updating the results until the first coalesced update came in), and pass the appropriate result set as a Details<> in the notification, so the popup can get at it without having to know how the controller works under-the-hood.BUG=11742
Review URL: http://codereview.chromium.org/119116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17562 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete/autocomplete.h')
| -rw-r--r-- | chrome/browser/autocomplete/autocomplete.h | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/chrome/browser/autocomplete/autocomplete.h b/chrome/browser/autocomplete/autocomplete.h index c2b8edd..44664fc 100644 --- a/chrome/browser/autocomplete/autocomplete.h +++ b/chrome/browser/autocomplete/autocomplete.h @@ -736,10 +736,12 @@ class AutocompleteController : public ACProviderListener { // all providers will be done immediately. // // The controller will fire - // NOTIFY_AUTOCOMPLETE_CONTROLLER_SYNCHRONOUS_RESULTS_AVAILABLE from inside - // this call, and unless the query is stopped, will fire at least one (and - // prehaps more) NOTIFY_AUTOCOMPLETE_CONTROLLER_RESULTS_UPDATED later as more - // results come in (even if the query completes synchronously). + // AUTOCOMPLETE_CONTROLLER_SYNCHRONOUS_MATCHES_AVAILABLE from inside this + // call, and unless the query is stopped, will fire at least one (and perhaps + // more) AUTOCOMPLETE_CONTROLLER_RESULT_UPDATED later as more results come in + // (even if the query completes synchronously). Listeners should use the + // result set provided in the accompanying Details object to update + // themselves. void Start(const std::wstring& text, const std::wstring& desired_tld, bool prevent_inline_autocomplete, |