diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-08 20:33:29 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-08 20:33:29 +0000 |
| commit | dad08287b545cc0ac1dad630ea7fa259e9b1ee8b (patch) | |
| tree | c8d56d7a70d0d4ee06c64bd000959bf63090b46b /chrome/browser/autocomplete/autocomplete_popup_model.h | |
| parent | 2792ca8fb1e0f75c5f2cac2f04c002778e20afa8 (diff) | |
| download | chromium_src-dad08287b545cc0ac1dad630ea7fa259e9b1ee8b.zip chromium_src-dad08287b545cc0ac1dad630ea7fa259e9b1ee8b.tar.gz chromium_src-dad08287b545cc0ac1dad630ea7fa259e9b1ee8b.tar.bz2 | |
Fix regression where hitting enter in the Omnibox would ignore recent editing.
Sadly, the only way I could find to fix this was a latest_result() accessor, because when the user hits enter, we really do need to use the very latest results. This just highlights how more of this stuff should move to the AutocompleteController.
BUG=13428
TEST=Type "food.c" and wait for the popup to stabilize. Then _very_ quickly type "om" and hit enter. You should navigate to food.com instead of searching for "food.c".
Review URL: http://codereview.chromium.org/118398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17891 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete/autocomplete_popup_model.h')
| -rw-r--r-- | chrome/browser/autocomplete/autocomplete_popup_model.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_popup_model.h b/chrome/browser/autocomplete/autocomplete_popup_model.h index 94772e6..c0c6185 100644 --- a/chrome/browser/autocomplete/autocomplete_popup_model.h +++ b/chrome/browser/autocomplete/autocomplete_popup_model.h @@ -86,6 +86,9 @@ class AutocompletePopupModel : public NotificationObserver { // If |alternate_nav_url| is non-NULL, it will be set to the alternate // navigation URL for |url| if one exists, or left unchanged otherwise. See // comments on AutocompleteResult::GetAlternateNavURL(). + // + // TODO(pkasting): When manually_selected_match_ moves to the controller, this + // can move too. GURL URLsForCurrentSelection( PageTransition::Type* transition, bool* is_history_what_you_typed_match, |