diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-03 00:54:54 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-03 00:54:54 +0000 |
| commit | 517d66832fe91abf83de51d1a6d3413cf183f9bd (patch) | |
| tree | 3d70b100eb6248091a45cdef5ed35ac03ec30b6b /chrome/browser/autocomplete/autocomplete_unittest.cc | |
| parent | 20c49681dbea46b5864a754a98d4d7252d11e9c6 (diff) | |
| download | chromium_src-517d66832fe91abf83de51d1a6d3413cf183f9bd.zip chromium_src-517d66832fe91abf83de51d1a6d3413cf183f9bd.tar.gz chromium_src-517d66832fe91abf83de51d1a6d3413cf183f9bd.tar.bz2 | |
Fix a number of problems caused by the AutocompleteController purposefully committing out-of-date results after the edit had changed. Simply not doing this commit would make the popup appear less responsive, so instead we're more careful to not try and update the edit with the out-of-date data, and instead force the popup to get newer results in cases where it might have been out-of-date.
BUG=46315
TEST=Type a letter that inline autocompletes, then immediately hit ctrl-a. You should get everything selected, not nothing. Also, typing a letter that inline autocompletes, then immediately a random other letter and the down arrow key, should show a popup with results for the two letters you typed, not just the first.
Review URL: http://codereview.chromium.org/3047041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54649 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete/autocomplete_unittest.cc')
| -rw-r--r-- | chrome/browser/autocomplete/autocomplete_unittest.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_unittest.cc b/chrome/browser/autocomplete/autocomplete_unittest.cc index f8081e7..e4f3b92 100644 --- a/chrome/browser/autocomplete/autocomplete_unittest.cc +++ b/chrome/browser/autocomplete/autocomplete_unittest.cc @@ -123,9 +123,6 @@ class AutocompleteProviderTest : public testing::Test, void AutocompleteProviderTest::SetUp() { registrar_.Add(this, NotificationType::AUTOCOMPLETE_CONTROLLER_RESULT_UPDATED, NotificationService::AllSources()); - registrar_.Add(this, - NotificationType::AUTOCOMPLETE_CONTROLLER_DEFAULT_MATCH_UPDATED, - NotificationService::AllSources()); ResetController(false); } |