diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-12 19:19:02 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-12 19:19:02 +0000 |
| commit | a28e956638c4bc0248bbd9f818349b41579fec85 (patch) | |
| tree | a141d381b1a2976fb271d66164e1997c636088aa /chrome/browser/autocomplete/autocomplete_unittest.cc | |
| parent | e57757c6e2a965fea7bd009dbe3f9284963e2509 (diff) | |
| download | chromium_src-a28e956638c4bc0248bbd9f818349b41579fec85.zip chromium_src-a28e956638c4bc0248bbd9f818349b41579fec85.tar.gz chromium_src-a28e956638c4bc0248bbd9f818349b41579fec85.tar.bz2 | |
Omnibox metrics logging patch splitout, part 2: Remove the AutocompleteMatch NULL constructor. It's too easy to forget to set various members with this.
The changes from .resize() to .erase() are necessary because the compiler doesn't know resize() won't be enlarging the vector and thus needing to access the NULL constructor. The changes to the HistoryContents shortcut code were similarly necessary to avoid a NULL construction, but in the end I think made the resulting code a bit clearer.
Review URL: http://codereview.chromium.org/10837
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5271 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete/autocomplete_unittest.cc')
| -rw-r--r-- | chrome/browser/autocomplete/autocomplete_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_unittest.cc b/chrome/browser/autocomplete/autocomplete_unittest.cc index 27d4ccb..386207c 100644 --- a/chrome/browser/autocomplete/autocomplete_unittest.cc +++ b/chrome/browser/autocomplete/autocomplete_unittest.cc @@ -257,8 +257,8 @@ TEST(AutocompleteMatch, MoreRelevant) { { -5, -10, false }, }; - AutocompleteMatch m1; - AutocompleteMatch m2; + AutocompleteMatch m1(NULL, 0, false); + AutocompleteMatch m2(NULL, 0, false); for (int i = 0; i < arraysize(cases); ++i) { m1.relevance = cases[i].r1; |