Omnibox: Pass Current Page Classification to Providers

This will allow, for instance, search provider to be more aggressive if
the user is on a search results page.

This change is actually small.  It merely looks big because it
changes the constructor to AutocompleteInput and that's used in
many places.

I also cleaned up a few comments while I'm touching these files.

When revising tests, I generally set the page classification to
INVALID_SPEC except for browser_tests and interactive_tests.  Those
tests are typically written to see how the browser behaves on startup.
For those, it felt more correct to set the page classification input to
NEW_TAB_PAGE.

TODO:
* create bug to track follow-up work to make this new parameter settable
  via about:omnibox
* create bug to track follow-up work to make AutocompleteClassifier get
  and pass along the current URL for its attempt to classify the query

TBR=pkasting@chromium.org

BUG=263823,237284

Review URL: https://codereview.chromium.org/20030003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214386 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 2 insertions, 2 deletions

diff --git a/chrome/browser/autocomplete/builtin_provider_unittest.cc b/chrome/browser/autocomplete/builtin_provider_unittest.cc
index 0315dc6..014b042 100644
--- a/chrome/browser/autocomplete/builtin_provider_unittest.cc
+++ b/chrome/browser/autocomplete/builtin_provider_unittest.cc
@@ -53,8 +53,8 @@ void BuiltinProviderTest::RunTest(test_data<ResultType>* builtin_cases,
   ACMatches matches;
   for (int i = 0; i < num_cases; ++i) {
     AutocompleteInput input(builtin_cases[i].input, string16::npos, string16(),
-                            GURL(), true, false, true,
-                            AutocompleteInput::ALL_MATCHES);
+                            GURL(), AutocompleteInput::INVALID_SPEC, true,
+                            false, true, AutocompleteInput::ALL_MATCHES);
     builtin_provider_->Start(input, false);
     EXPECT_TRUE(builtin_provider_->done());
     matches = builtin_provider_->matches();