diff options
| author | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-09 16:10:06 +0000 |
|---|---|---|
| committer | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-09 16:10:06 +0000 |
| commit | adf650f2036694291449d4fb2f6b71b5ecccc331 (patch) | |
| tree | b5b541d31d7043133ed593888ef80855046311c4 /chrome/browser/autocomplete/history_contents_provider.cc | |
| parent | 33c1d279a502d0f6a78870bfa2c0465b7ecdd307 (diff) | |
| download | chromium_src-adf650f2036694291449d4fb2f6b71b5ecccc331.zip chromium_src-adf650f2036694291449d4fb2f6b71b5ecccc331.tar.gz chromium_src-adf650f2036694291449d4fb2f6b71b5ecccc331.tar.bz2 | |
I tried running the browser in Purify and the browser crashed on me.
Basically, the animations were really slow and at one point I got
a NULL pointer read because TabContents was NULL while updating
the animations.
Call stack:
TabContents::is_loading(void)const [browser\tab_contents.h:214]
Browser::IsCurrentPageLoading(void)const [browser\browser.cc:400]
BrowserView::LoadingAnimationCallback(void) [browser\views\frame\browser_view.cc:1325]
... removed Timer calls for clarity...
We already check the return value of GetSelectedTabContents in many
places. It makes sense to do it here also, I think.
Review URL: http://codereview.chromium.org/13647
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6587 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete/history_contents_provider.cc')
0 files changed, 0 insertions, 0 deletions