diff options
| author | mrossetti@chromium.org <mrossetti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-21 14:01:15 +0000 |
|---|---|---|
| committer | mrossetti@chromium.org <mrossetti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-21 14:01:15 +0000 |
| commit | 579006cb986916ca2d50875b9f0b472e6b6039d1 (patch) | |
| tree | fd9a98952eb78358eb20644a87578da6356f3b77 /chrome/browser/autocomplete/history_quick_provider.cc | |
| parent | e90d24102c73e7593d95446ff039ef0e498bc411 (diff) | |
| download | chromium_src-579006cb986916ca2d50875b9f0b472e6b6039d1.zip chromium_src-579006cb986916ca2d50875b9f0b472e6b6039d1.tar.gz chromium_src-579006cb986916ca2d50875b9f0b472e6b6039d1.tar.bz2 | |
Better Cache HQP Results for Terms.
The way results for search terms being incrementally typed into the omnibox were being handled was flawed, causing terms other than the current complete word to be reprocessed on each keystroke. The caching mechanism was corrected with improved performance in the general case and dramatic performance improvement in the case of longer strings being typed into the omnibox.
Remove temporary workaround from http://codereview.chromium.org/7461001/.
BUG=88498,89728
TEST=Unit test updated to verify that search term results are being cached. Manual: Type a very long string into the omnibox and verify that typing is not slowed. Also backspace both at the end of and at other places in the string and verify that typing is responsive. Also type new terms both at the end of and at other places in the string. Also delete words in the string in various places.
Review URL: http://codereview.chromium.org/7395035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93385 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete/history_quick_provider.cc')
| -rw-r--r-- | chrome/browser/autocomplete/history_quick_provider.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/chrome/browser/autocomplete/history_quick_provider.cc b/chrome/browser/autocomplete/history_quick_provider.cc index d678ae45..57c9d11 100644 --- a/chrome/browser/autocomplete/history_quick_provider.cc +++ b/chrome/browser/autocomplete/history_quick_provider.cc @@ -93,10 +93,6 @@ void HistoryQuickProvider::DeleteMatch(const AutocompleteMatch& match) {} void HistoryQuickProvider::DoAutocomplete() { // Get the matching URLs from the DB. string16 term_string = autocomplete_input_.text(); - // TODO(mrossetti): Temporary workaround for http://crbug.com/88498. - // Just give up after 50 characters. - if (term_string.size() > 50) - return; term_string = UnescapeURLComponent(term_string, UnescapeRule::SPACES | UnescapeRule::URL_SPECIAL_CHARS); history::InMemoryURLIndex::String16Vector terms( |