diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-27 03:59:31 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-27 03:59:31 +0000 |
| commit | d85cf074f2186dbe1cf8a9db5d89a2b817ffb0e1 (patch) | |
| tree | e03156e3142955f7cf637fe404a1ce2c6f7aaaf4 /chrome/browser/autocomplete/search_provider_unittest.cc | |
| parent | 76a188be4e3ddc42c42beabfeeeb618b2adae11e (diff) | |
| download | chromium_src-d85cf074f2186dbe1cf8a9db5d89a2b817ffb0e1.zip chromium_src-d85cf074f2186dbe1cf8a9db5d89a2b817ffb0e1.tar.gz chromium_src-d85cf074f2186dbe1cf8a9db5d89a2b817ffb0e1.tar.bz2 | |
Simplify threading in browser thread by making only ChromeThread deal with different thread lifetimes.The rest of the code doesn't get MessageLoop pointers since they're not thread-safe and instead just call PostTask on ChromeThread. If the target thread is not alive, then the task is simply deleted.In a followup change, I'll remove any remaining MessageLoop* caching. With this change, there's little to be gained by caching since no locks are involved if the target MessageLoop is guaranteed to outlive the current thread (inferred automatically by the order of the chrome_threads_ array).BUG=25354
Review URL: http://codereview.chromium.org/306032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30163 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete/search_provider_unittest.cc')
| -rw-r--r-- | chrome/browser/autocomplete/search_provider_unittest.cc | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/chrome/browser/autocomplete/search_provider_unittest.cc b/chrome/browser/autocomplete/search_provider_unittest.cc index 493df22..b5f9bcd 100644 --- a/chrome/browser/autocomplete/search_provider_unittest.cc +++ b/chrome/browser/autocomplete/search_provider_unittest.cc @@ -6,6 +6,7 @@ #include "base/time.h" #include "build/build_config.h" #include "chrome/browser/autocomplete/search_provider.h" +#include "chrome/browser/chrome_thread.h" #include "chrome/browser/history/history.h" #include "chrome/browser/net/test_url_fetcher_factory.h" #include "chrome/browser/search_engines/template_url.h" @@ -31,7 +32,10 @@ class SearchProviderTest : public testing::Test, term1_(L"term1"), keyword_t_url_(NULL), keyword_term_(L"keyword"), - quit_when_done_(false) {} + io_thread_(ChromeThread::IO), + quit_when_done_(false) { + io_thread_.Start(); + } // See description above class for what this registers. virtual void SetUp(); @@ -62,11 +66,12 @@ class SearchProviderTest : public testing::Test, const std::wstring keyword_term_; GURL keyword_url_; + MessageLoopForUI message_loop_; + ChromeThread io_thread_; + // URLFetcher::Factory implementation registered. TestURLFetcherFactory test_factory_; - MessageLoopForUI message_loop_; - // Profile we use. TestingProfile profile_; |