summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
diff options
context:
space:
mode:
authorpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-12-16 01:41:00 +0000
committerpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-12-16 01:41:00 +0000
commit381e299978874f38b6c9af4afdac1f9d05bb4a29 (patch)
treefc283d9557989ca270a91b8f04126553d869fc0b /chrome/browser/autocomplete
parent46eb7524e7b991f5a750773ee11e37979df359df (diff)
downloadchromium_src-381e299978874f38b6c9af4afdac1f9d05bb4a29.zip
chromium_src-381e299978874f38b6c9af4afdac1f9d05bb4a29.tar.gz
chromium_src-381e299978874f38b6c9af4afdac1f9d05bb4a29.tar.bz2
Omnibox metrics logging patch splitout, part 6: Log more omnibox data (client side).
This is the last patch. It can't go in until Evan and I test it. Review URL: http://codereview.chromium.org/10666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7032 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete')
-rw-r--r--chrome/browser/autocomplete/autocomplete.h4
-rw-r--r--chrome/browser/autocomplete/autocomplete_popup.cc4
2 files changed, 6 insertions, 2 deletions
diff --git a/chrome/browser/autocomplete/autocomplete.h b/chrome/browser/autocomplete/autocomplete.h
index 2e26102..79095ad 100644
--- a/chrome/browser/autocomplete/autocomplete.h
+++ b/chrome/browser/autocomplete/autocomplete.h
@@ -788,16 +788,20 @@ class AutocompleteController : public ACProviderListener {
// from the omnibox popup.
struct AutocompleteLog {
AutocompleteLog(std::wstring text,
+ AutocompleteInput::Type input_type,
size_t selected_index,
size_t inline_autocompleted_length,
const AutocompleteResult& result)
: text(text),
+ input_type(input_type),
selected_index(selected_index),
inline_autocompleted_length(inline_autocompleted_length),
result(result) {
}
// The user's input text in the omnibox.
std::wstring text;
+ // The detected type of the user's input.
+ AutocompleteInput::Type input_type;
// Selected index (if selected) or -1 (AutocompletePopupModel::kNoMatch).
size_t selected_index;
// Inline autocompleted length (if displayed).
diff --git a/chrome/browser/autocomplete/autocomplete_popup.cc b/chrome/browser/autocomplete/autocomplete_popup.cc
index d9ca65a..23535c3 100644
--- a/chrome/browser/autocomplete/autocomplete_popup.cc
+++ b/chrome/browser/autocomplete/autocomplete_popup.cc
@@ -869,8 +869,8 @@ bool AutocompletePopupModel::GetKeywordForMatch(const AutocompleteMatch& match,
}
AutocompleteLog* AutocompletePopupModel::GetAutocompleteLog() {
- return new AutocompleteLog(controller_->input().text(), selected_line_, 0,
- controller_->result());
+ return new AutocompleteLog(controller_->input().text(),
+ controller_->input().type(), selected_line_, 0, controller_->result());
}
void AutocompletePopupModel::Move(int count) {