diff options
| author | jered@chromium.org <jered@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-20 19:17:11 +0000 |
|---|---|---|
| committer | jered@chromium.org <jered@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-20 19:17:11 +0000 |
| commit | 1aedaaa08397171253d1aa0a99951d96a52fe2a9 (patch) | |
| tree | 77c2e9072373ed125685f9de3ef9db3ce28b6f7a /chrome/browser/autocomplete | |
| parent | 437993992f220cfc9254f311ddad5838c4f6da66 (diff) | |
| download | chromium_src-1aedaaa08397171253d1aa0a99951d96a52fe2a9.zip chromium_src-1aedaaa08397171253d1aa0a99951d96a52fe2a9.tar.gz chromium_src-1aedaaa08397171253d1aa0a99951d96a52fe2a9.tar.bz2 | |
Zero suggest: Do not notify listener if no results.
This fixes a bug where, when the user first focuses in the omnibox on an
HTTP URL with no suggestions, we erase the URL.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10947045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157807 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete')
| -rw-r--r-- | chrome/browser/autocomplete/zero_suggest_provider.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/chrome/browser/autocomplete/zero_suggest_provider.cc b/chrome/browser/autocomplete/zero_suggest_provider.cc index 2d76c9c..d7b0bc8 100644 --- a/chrome/browser/autocomplete/zero_suggest_provider.cc +++ b/chrome/browser/autocomplete/zero_suggest_provider.cc @@ -101,13 +101,15 @@ void ZeroSuggestProvider::OnURLFetchComplete(const net::URLFetcher* source) { JSONStringValueSerializer deserializer(json_data); deserializer.set_allow_trailing_comma(true); scoped_ptr<Value> data(deserializer.Deserialize(NULL, NULL)); - results_updated = data.get() && ParseSuggestResults(data.get()); + results_updated = + data.get() && ParseSuggestResults(data.get()) && !results_.empty(); } done_ = true; - ConvertResultsToAutocompleteMatches(); - if (results_updated) + if (results_updated) { + ConvertResultsToAutocompleteMatches(); listener_->OnProviderUpdate(true); + } } ZeroSuggestProvider::~ZeroSuggestProvider() { |