diff options
| author | mpearson@chromium.org <mpearson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-22 01:01:34 +0000 |
|---|---|---|
| committer | mpearson@chromium.org <mpearson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-22 01:01:34 +0000 |
| commit | 1bea45ecc5fec1ff6e3c7b659480e05e373afd9b (patch) | |
| tree | a858bdf884e9036eadbaf109fe568f9ecc618a9c /chrome/browser/autocomplete | |
| parent | 086f0b984bd3702be15cc49414fe942e440cb3a6 (diff) | |
| download | chromium_src-1bea45ecc5fec1ff6e3c7b659480e05e373afd9b.zip chromium_src-1bea45ecc5fec1ff6e3c7b659480e05e373afd9b.tar.gz chromium_src-1bea45ecc5fec1ff6e3c7b659480e05e373afd9b.tar.bz2 | |
Omnibox: Don't Force Notify Default Match Changed When Expiring Old Matches
Previously, we force the autocomplete controller to notify the edit model that the edit default match has changed when we expire old matches, even if the default match didn't change. This removes that forcing code.
I tested it on Linux for a bit. Everything looks fine to me. I didn't see any jankiness. Let's hope the other platforms are the same.
BUG=
TEST=by hand playing with the omnibox on Linux for five minutes
Review URL: https://chromiumcodereview.appspot.com/11316141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169180 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete')
| -rw-r--r-- | chrome/browser/autocomplete/autocomplete_controller.cc | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_controller.cc b/chrome/browser/autocomplete/autocomplete_controller.cc index e745381..26f5390 100644 --- a/chrome/browser/autocomplete/autocomplete_controller.cc +++ b/chrome/browser/autocomplete/autocomplete_controller.cc @@ -279,12 +279,7 @@ void AutocompleteController::ExpireCopiedEntries() { // The first true makes UpdateResult() clear out the results and // regenerate them, thus ensuring that no results from the previous // result set remain. - // The second true says to pretend the default match changed (even - // if it did not). This may not be necessary but the code has been - // like this for a long time and there's probably no great benefit in - // changing it. Classically we have erred on the side of notifying - // too often because it hasn't had any major side effects. - UpdateResult(true, true); + UpdateResult(true, false); } void AutocompleteController::OnProviderUpdate(bool updated_matches) { |