diff options
| author | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-12 20:13:19 +0000 |
|---|---|---|
| committer | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-12 20:13:19 +0000 |
| commit | 0ceaf4e221365b7b9f054c38c320d4a77a510b74 (patch) | |
| tree | 2757655f4dece9fa385e7a608b51e8ec1f5701b4 /chrome/browser/autocomplete | |
| parent | d3dd31fb151f067389f3423ee6de09f8c5251ed9 (diff) | |
| download | chromium_src-0ceaf4e221365b7b9f054c38c320d4a77a510b74.zip chromium_src-0ceaf4e221365b7b9f054c38c320d4a77a510b74.tar.gz chromium_src-0ceaf4e221365b7b9f054c38c320d4a77a510b74.tar.bz2 | |
[Mac] Mouse clicks in omnibox close popup.
Previously a right-click in omnibox or on a page action would have a
context menu _and_ the omnibox popup. Clicking a page action or star
would mess up the omnibox selection. This brings things in line with
other platforms.
Also fix to not change selection if an omnibox decoration handles the click.
BUG=40145
TEST=Clicking star with omnibox popup up should close popup.
TEST=Clicking star should not change omnibox selection.
TEST=Right-click in omnibox with popup up should close popup.
Review URL: http://codereview.chromium.org/2900006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52126 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete')
| -rw-r--r-- | chrome/browser/autocomplete/autocomplete_edit_view_mac.h | 1 | ||||
| -rw-r--r-- | chrome/browser/autocomplete/autocomplete_edit_view_mac.mm | 4 |
2 files changed, 0 insertions, 5 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_mac.h b/chrome/browser/autocomplete/autocomplete_edit_view_mac.h index c2aea1f..ae9a900 100644 --- a/chrome/browser/autocomplete/autocomplete_edit_view_mac.h +++ b/chrome/browser/autocomplete/autocomplete_edit_view_mac.h @@ -86,7 +86,6 @@ class AutocompleteEditViewMac : public AutocompleteEditView, virtual int GetPasteActionStringId(); virtual void OnPasteAndGo(); virtual void OnFrameChanged(); - virtual void OnDidResignKey(); // Closes the popup. virtual void OnDidBeginEditing(); virtual void OnDidChange(); virtual void OnDidEndEditing(); diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm b/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm index a360455..736525d 100644 --- a/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm +++ b/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm @@ -748,10 +748,6 @@ void AutocompleteEditViewMac::OnKillFocus() { controller_->OnKillFocus(); } -void AutocompleteEditViewMac::OnDidResignKey() { - ClosePopup(); -} - bool AutocompleteEditViewMac::CanCopy() { const NSRange selection = GetSelectedRange(); return selection.length > 0; |