summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autofill/autofill_download_unittest.cc
diff options
context:
space:
mode:
authorisherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-21 00:28:28 +0000
committerisherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-21 00:28:28 +0000
commitc956e3267c0653cbc839f0618754c4086605d195 (patch)
tree21bc8da830aa2fe28e807db43b417bcf764b602a /chrome/browser/autofill/autofill_download_unittest.cc
parentf05238129389df881de4e1702dc9c0f9d3746c07 (diff)
downloadchromium_src-c956e3267c0653cbc839f0618754c4086605d195.zip
chromium_src-c956e3267c0653cbc839f0618754c4086605d195.tar.gz
chromium_src-c956e3267c0653cbc839f0618754c4086605d195.tar.bz2
Don't pass around ScopedVectors(), prefer passing std::vector instead.
BUG=none TEST=none Review URL: http://codereview.chromium.org/8229033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106646 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autofill/autofill_download_unittest.cc')
-rw-r--r--chrome/browser/autofill/autofill_download_unittest.cc20
1 files changed, 10 insertions, 10 deletions
diff --git a/chrome/browser/autofill/autofill_download_unittest.cc b/chrome/browser/autofill/autofill_download_unittest.cc
index 4e9724b..4c72e7d 100644
--- a/chrome/browser/autofill/autofill_download_unittest.cc
+++ b/chrome/browser/autofill/autofill_download_unittest.cc
@@ -216,7 +216,7 @@ TEST_F(AutofillDownloadTest, QueryAndUploadTest) {
MockAutofillMetrics mock_metric_logger;
EXPECT_CALL(mock_metric_logger,
LogServerQueryMetric(AutofillMetrics::QUERY_SENT)).Times(1);
- EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures,
+ EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures.get(),
mock_metric_logger));
// Set upload to 100% so requests happen.
download_manager_.SetPositiveUploadRate(1.0);
@@ -308,7 +308,7 @@ TEST_F(AutofillDownloadTest, QueryAndUploadTest) {
// Request with id 3.
EXPECT_CALL(mock_metric_logger,
LogServerQueryMetric(AutofillMetrics::QUERY_SENT)).Times(1);
- EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures,
+ EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures.get(),
mock_metric_logger));
fetcher = factory.GetFetcherByID(3);
ASSERT_TRUE(fetcher);
@@ -326,7 +326,7 @@ TEST_F(AutofillDownloadTest, QueryAndUploadTest) {
// Query requests should be ignored for the next 10 seconds.
EXPECT_CALL(mock_metric_logger,
LogServerQueryMetric(AutofillMetrics::QUERY_SENT)).Times(0);
- EXPECT_FALSE(download_manager_.StartQueryRequest(form_structures,
+ EXPECT_FALSE(download_manager_.StartQueryRequest(form_structures.get(),
mock_metric_logger));
fetcher = factory.GetFetcherByID(4);
EXPECT_EQ(NULL, fetcher);
@@ -425,7 +425,7 @@ TEST_F(AutofillDownloadTest, CacheQueryTest) {
MockAutofillMetrics mock_metric_logger;
EXPECT_CALL(mock_metric_logger,
LogServerQueryMetric(AutofillMetrics::QUERY_SENT)).Times(1);
- EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures0,
+ EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures0.get(),
mock_metric_logger));
// No responses yet
EXPECT_EQ(static_cast<size_t>(0), responses_.size());
@@ -441,7 +441,7 @@ TEST_F(AutofillDownloadTest, CacheQueryTest) {
// No actual request - should be a cache hit.
EXPECT_CALL(mock_metric_logger,
LogServerQueryMetric(AutofillMetrics::QUERY_SENT)).Times(1);
- EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures0,
+ EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures0.get(),
mock_metric_logger));
// Data is available immediately from cache - no over-the-wire trip.
ASSERT_EQ(static_cast<size_t>(1), responses_.size());
@@ -451,7 +451,7 @@ TEST_F(AutofillDownloadTest, CacheQueryTest) {
// Request with id 1.
EXPECT_CALL(mock_metric_logger,
LogServerQueryMetric(AutofillMetrics::QUERY_SENT)).Times(1);
- EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures1,
+ EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures1.get(),
mock_metric_logger));
// No responses yet
EXPECT_EQ(static_cast<size_t>(0), responses_.size());
@@ -467,7 +467,7 @@ TEST_F(AutofillDownloadTest, CacheQueryTest) {
// Request with id 2.
EXPECT_CALL(mock_metric_logger,
LogServerQueryMetric(AutofillMetrics::QUERY_SENT)).Times(1);
- EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures2,
+ EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures2.get(),
mock_metric_logger));
fetcher = factory.GetFetcherByID(2);
@@ -481,12 +481,12 @@ TEST_F(AutofillDownloadTest, CacheQueryTest) {
// No actual requests - should be a cache hit.
EXPECT_CALL(mock_metric_logger,
LogServerQueryMetric(AutofillMetrics::QUERY_SENT)).Times(1);
- EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures1,
+ EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures1.get(),
mock_metric_logger));
EXPECT_CALL(mock_metric_logger,
LogServerQueryMetric(AutofillMetrics::QUERY_SENT)).Times(1);
- EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures2,
+ EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures2.get(),
mock_metric_logger));
ASSERT_EQ(static_cast<size_t>(2), responses_.size());
@@ -498,7 +498,7 @@ TEST_F(AutofillDownloadTest, CacheQueryTest) {
// Request with id 3.
EXPECT_CALL(mock_metric_logger,
LogServerQueryMetric(AutofillMetrics::QUERY_SENT)).Times(1);
- EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures0,
+ EXPECT_TRUE(download_manager_.StartQueryRequest(form_structures0.get(),
mock_metric_logger));
// No responses yet
EXPECT_EQ(static_cast<size_t>(0), responses_.size());