diff options
author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-13 02:58:20 +0000 |
---|---|---|
committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-13 02:58:20 +0000 |
commit | 280356aaff018a2b33defe80d0c4c73c81883c44 (patch) | |
tree | b1dc5edc46757eb911d6112acf38284b7f306918 /chrome/browser/autofill/credit_card.cc | |
parent | a1aee38539cdd177ce3f034677f55327051e3763 (diff) | |
download | chromium_src-280356aaff018a2b33defe80d0c4c73c81883c44.zip chromium_src-280356aaff018a2b33defe80d0c4c73c81883c44.tar.gz chromium_src-280356aaff018a2b33defe80d0c4c73c81883c44.tar.bz2 |
Adding summary string generation for the AutoFill feature.
Includes a small modification to the generated resources, needed additional whitespace
in credit card summary. Added summary generation to autofill_profile.* and modified
summary generation in credit_card.* to match. credit_card.* modifications were largely
to use string16 instead of std::wstring.
Factored out common unit testing utilities into autofill_common_unittest.*, and added
unit tests for summary string generation for credit_card.* and autofill_profile.*.
BUG=35551
TEST=unit_tests --gtest_filter=AutoFillProfileTest.*:CreditCardTest.*
Review URL: http://codereview.chromium.org/606031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39002 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autofill/credit_card.cc')
-rw-r--r-- | chrome/browser/autofill/credit_card.cc | 25 |
1 files changed, 12 insertions, 13 deletions
diff --git a/chrome/browser/autofill/credit_card.cc b/chrome/browser/autofill/credit_card.cc index e32ccf1..1d4ba55 100644 --- a/chrome/browser/autofill/credit_card.cc +++ b/chrome/browser/autofill/credit_card.cc @@ -262,27 +262,26 @@ void CreditCard::set_expiration_year(int expiration_year) { expiration_year_ = expiration_year; } -std::wstring CreditCard::PreviewSummary() const { - // TODO(georgey): add unit-test - std::wstring preview; +string16 CreditCard::PreviewSummary() const { + string16 preview; if (number().empty()) return preview; // No CC number, means empty preview. - std::wstring obfuscated_cc_number(L"************"); - obfuscated_cc_number.append(UTF16ToWide(last_four_digits())); + string16 obfuscated_cc_number(ASCIIToUTF16("************")); + obfuscated_cc_number.append(last_four_digits()); if (!expiration_month() || !expiration_year()) return obfuscated_cc_number; // no expiration date set // TODO(georgey): internationalize date - std::wstring formatted_date(UTF16ToWide(ExpirationMonthAsString())); - formatted_date.append(L"/"); - formatted_date.append(UTF16ToWide(Expiration4DigitYearAsString())); - - preview = l10n_util::GetStringF(IDS_CREDIT_CARD_NUMBER_PREVIEW_FORMAT, - obfuscated_cc_number, - formatted_date); + string16 formatted_date(ExpirationMonthAsString()); + formatted_date.append(ASCIIToUTF16("/")); + formatted_date.append(Expiration4DigitYearAsString()); + + preview = l10n_util::GetStringFUTF16( + IDS_CREDIT_CARD_NUMBER_PREVIEW_FORMAT, + obfuscated_cc_number, + formatted_date); return preview; } - void CreditCard::operator=(const CreditCard& source) { number_ = source.number_; name_on_card_ = source.name_on_card_; |