diff options
| author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-22 18:27:16 +0000 |
|---|---|---|
| committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-22 18:27:16 +0000 |
| commit | 2f28c5684b55211bd4ea28b4407128e0ae86ddee (patch) | |
| tree | 76fd841eb9fd731cbdbc15cf7785b5d12db63a53 /chrome/browser/autofill/form_structure_unittest.cc | |
| parent | 8fd16f505f13dc080adc7a1aaa1f64fc7fe17bd7 (diff) | |
| download | chromium_src-2f28c5684b55211bd4ea28b4407128e0ae86ddee.zip chromium_src-2f28c5684b55211bd4ea28b4407128e0ae86ddee.tar.gz chromium_src-2f28c5684b55211bd4ea28b4407128e0ae86ddee.tar.bz2 | |
AutoFill crash in FormStructure::GetHeuristicAutoFillTypes().
Fixes over-delete in FormStructure::GetHeuristicFieldInfo and adds defensive checks for NULL in FormStructure::GetHeuristicAutoFillTypes().
Also makes explicit copy constructors for various form field types.
BUG=42211
TEST=FormStructureTest
Review URL: http://codereview.chromium.org/1744005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45333 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autofill/form_structure_unittest.cc')
| -rw-r--r-- | chrome/browser/autofill/form_structure_unittest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/autofill/form_structure_unittest.cc b/chrome/browser/autofill/form_structure_unittest.cc index ad0b383..8230364 100644 --- a/chrome/browser/autofill/form_structure_unittest.cc +++ b/chrome/browser/autofill/form_structure_unittest.cc @@ -338,7 +338,7 @@ TEST(FormStructureTest, HeuristicsSample8) { EXPECT_EQ(ADDRESS_HOME_STATE, form_structure->field(5)->heuristic_type()); // Zip. EXPECT_EQ(ADDRESS_HOME_ZIP, form_structure->field(6)->heuristic_type()); - // Zip. + // Country. EXPECT_EQ(ADDRESS_HOME_COUNTRY, form_structure->field(7)->heuristic_type()); // Phone. EXPECT_EQ(PHONE_HOME_WHOLE_NUMBER, |