diff options
| author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-14 04:02:53 +0000 |
|---|---|---|
| committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-14 04:02:53 +0000 |
| commit | 5db9d5a395c6f36c37b2492a3875bb734e15f6f7 (patch) | |
| tree | 9e47e26e385c55b200a1d51f426fdd369c8c9f65 /chrome/browser/autofill | |
| parent | 1d594bafeff18a8f5a3257acb2bc64c06f8f3367 (diff) | |
| download | chromium_src-5db9d5a395c6f36c37b2492a3875bb734e15f6f7.zip chromium_src-5db9d5a395c6f36c37b2492a3875bb734e15f6f7.tar.gz chromium_src-5db9d5a395c6f36c37b2492a3875bb734e15f6f7.tar.bz2 | |
AutoFill credit card Valgrind errors.
Changes AutoFill CreditCard class to initialize billing_address_id_ member in constructors. This was causing initialization errors to be flagged in Valgrind on Mac and Linux. Initializing member to 0 fixes Valgrind.
Suppression (error hash=#FFFFFFFFF153AE3B#):
{
<insert_a_suppression_name_here>
Memcheck:Cond
fun:__udivdi3
fun:sqlite3VXPrintf
fun:sqlite3_snprintf
fun:sqlite3VdbeMemStringify
fun:applyAffinity
fun:sqlite3VdbeExec
fun:sqlite3Step
fun:sqlite3_step
fun:_ZN3sql9Statement3RunEv
fun:_ZN11WebDatabase13AddCreditCardERK10CreditCard
fun:_ZN14WebDataService17AddCreditCardImplEPNS_14GenericRequestI10CreditCardEE
fun:_Z16DispatchToMethodI14WebDataServiceMS0_FvPNS0_14GenericRequestI10CreditCardEEES4_EvPT_T0_RK6Tuple1IT1_E
fun:_ZN14RunnableMethodI14WebDataServiceMS0_FvPNS0_14GenericRequestI10CreditCardEEE6Tuple1IS4_EE3RunEv
fun:_ZN11MessageLoop7RunTaskEP4Task
fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE
fun:_ZN11MessageLoop6DoWorkEv
fun:_ZN4base18MessagePumpDefault3RunEPNS_11MessagePump8DelegateE
fun:_ZN11MessageLoop11RunInternalEv
fun:_ZN11MessageLoop10RunHandlerEv
}
etc.
http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/7521/steps/memory%20test:%20unit/logs/stdio
http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(valgrind)(1)/builds/5915/steps/memory%20test:%20unit/logs/stdio
BUG=49094
TEST=Run Valgrind, verify no leaks or errors reported.
TBR=jhawkins
Review URL: http://codereview.chromium.org/3422001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59333 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autofill')
| -rw-r--r-- | chrome/browser/autofill/credit_card.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/browser/autofill/credit_card.cc b/chrome/browser/autofill/credit_card.cc index b643da5..86cb365 100644 --- a/chrome/browser/autofill/credit_card.cc +++ b/chrome/browser/autofill/credit_card.cc @@ -129,6 +129,7 @@ CreditCard::CreditCard(const string16& label, int unique_id) : expiration_month_(0), expiration_year_(0), label_(label), + billing_address_id_(0), unique_id_(unique_id) { } @@ -139,6 +140,7 @@ CreditCard::CreditCard(const CreditCard& card) : FormGroup() { CreditCard::CreditCard() : expiration_month_(0), expiration_year_(0), + billing_address_id_(0), unique_id_(0) { } |