summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autofill
diff options
context:
space:
mode:
authorcsharp@chromium.org <csharp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-04 04:03:21 +0000
committercsharp@chromium.org <csharp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-04 04:03:21 +0000
commit8f3ec14d4d50898cbaf47326866f54f4fe446601 (patch)
tree8db994cf7922fee7752ac7ae6ed49e0516b4cf18 /chrome/browser/autofill
parentfa20ec8ad1a9df35a00846f24741a5f7e8669a87 (diff)
downloadchromium_src-8f3ec14d4d50898cbaf47326866f54f4fe446601.zip
chromium_src-8f3ec14d4d50898cbaf47326866f54f4fe446601.tar.gz
chromium_src-8f3ec14d4d50898cbaf47326866f54f4fe446601.tar.bz2
Ensure New Autofill UI Hides
Hide the new Autofill UI whenever the editing in the autofill field ends. This ensure we properly hide the UI when clicking on the omnibox. BUG=51644 TEST= Review URL: http://codereview.chromium.org/10348015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135287 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autofill')
-rw-r--r--chrome/browser/autofill/autofill_external_delegate.cc2
-rw-r--r--chrome/browser/autofill/autofill_external_delegate_unittest.cc8
2 files changed, 10 insertions, 0 deletions
diff --git a/chrome/browser/autofill/autofill_external_delegate.cc b/chrome/browser/autofill/autofill_external_delegate.cc
index 3516dd5..3420018 100644
--- a/chrome/browser/autofill/autofill_external_delegate.cc
+++ b/chrome/browser/autofill/autofill_external_delegate.cc
@@ -170,6 +170,8 @@ void AutofillExternalDelegate::RemoveAutofillProfileOrCreditCard(
void AutofillExternalDelegate::DidEndTextFieldEditing() {
+ HideAutofillPopup();
+
has_shown_autofill_popup_for_current_edit_ = false;
}
diff --git a/chrome/browser/autofill/autofill_external_delegate_unittest.cc b/chrome/browser/autofill/autofill_external_delegate_unittest.cc
index e557557..7c6131a 100644
--- a/chrome/browser/autofill/autofill_external_delegate_unittest.cc
+++ b/chrome/browser/autofill/autofill_external_delegate_unittest.cc
@@ -163,3 +163,11 @@ TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateClearPreviewedForm) {
EXPECT_CALL(*external_delegate_, ClearPreviewedForm()).Times(1);
external_delegate_->SelectAutofillSuggestionAtIndex(1);
}
+
+// Test that the popup is hidden once we are done editing the autofill field.
+TEST_F(AutofillExternalDelegateUnitTest,
+ ExternalDelegateHidePopupAfterEditing) {
+ EXPECT_CALL(*external_delegate_, HideAutofillPopup());
+
+ external_delegate_->DidEndTextFieldEditing();
+}