linux: build with -Wextra

95% of this is removing "const" from return types, but turning this
on found one bug!  (A "for" loop that expected its iterator to go negative but
which was using an unsigned type.)

BUG=34160

Review URL: http://codereview.chromium.org/570012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98

8 files changed, 18 insertions, 11 deletions

diff --git a/chrome/browser/autofill/address.cc b/chrome/browser/autofill/address.cc
index f39f141..c76f6af 100644
--- a/chrome/browser/autofill/address.cc
+++ b/chrome/browser/autofill/address.cc
@@ -153,7 +153,8 @@ void Address::set_line2(const string16& line2) {
 }
 
 Address::Address(const Address& address)
-    : line1_tokens_(address.line1_tokens_),
+    : FormGroup(),
+      line1_tokens_(address.line1_tokens_),
       line2_tokens_(address.line2_tokens_),
       line1_(address.line1_),
       line2_(address.line2_),
diff --git a/chrome/browser/autofill/address_field.cc b/chrome/browser/autofill/address_field.cc
index 0994ac6..a40ad87 100644
--- a/chrome/browser/autofill/address_field.cc
+++ b/chrome/browser/autofill/address_field.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -161,7 +161,8 @@ AddressField::AddressField()
 }
 
 AddressField::AddressField(const AddressField& field)
-    : address1_(field.address1_),
+    : FormField(),
+      address1_(field.address1_),
       address2_(field.address2_),
       city_(field.city_),
       state_(field.state_),
diff --git a/chrome/browser/autofill/autofill_profile.cc b/chrome/browser/autofill/autofill_profile.cc
index cd0438d..caf335a 100644
--- a/chrome/browser/autofill/autofill_profile.cc
+++ b/chrome/browser/autofill/autofill_profile.cc
@@ -32,7 +32,8 @@ AutoFillProfile::AutoFillProfile()
       use_billing_address_(true) {
 }
 
-AutoFillProfile::AutoFillProfile(const AutoFillProfile& source) {
+AutoFillProfile::AutoFillProfile(const AutoFillProfile& source)
+    : FormGroup() {
   operator=(source);
 }
 
diff --git a/chrome/browser/autofill/contact_info.cc b/chrome/browser/autofill/contact_info.cc
index 266ea8e..37c5714 100644
--- a/chrome/browser/autofill/contact_info.cc
+++ b/chrome/browser/autofill/contact_info.cc
@@ -150,7 +150,8 @@ string16 ContactInfo::MiddleInitial() const {
 }
 
 ContactInfo::ContactInfo(const ContactInfo& contact_info)
-    : first_tokens_(contact_info.first_tokens_),
+    : FormGroup(),
+      first_tokens_(contact_info.first_tokens_),
       middle_tokens_(contact_info.middle_tokens_),
       last_tokens_(contact_info.last_tokens_),
       first_(contact_info.first_),
diff --git a/chrome/browser/autofill/credit_card.cc b/chrome/browser/autofill/credit_card.cc
index 0f0d526..d4e5589 100644
--- a/chrome/browser/autofill/credit_card.cc
+++ b/chrome/browser/autofill/credit_card.cc
@@ -33,7 +33,7 @@ CreditCard::CreditCard(const string16& label, int unique_id)
       unique_id_(unique_id) {
 }
 
-CreditCard::CreditCard(const CreditCard& card) {
+CreditCard::CreditCard(const CreditCard& card) : FormGroup() {
   operator=(card);
 }
 
diff --git a/chrome/browser/autofill/credit_card_field.cc b/chrome/browser/autofill/credit_card_field.cc
index 7e0c3d0c..3a2bebc 100644
--- a/chrome/browser/autofill/credit_card_field.cc
+++ b/chrome/browser/autofill/credit_card_field.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -153,7 +153,8 @@ CreditCardField::CreditCardField()
 }
 
 CreditCardField::CreditCardField(const CreditCardField& field)
-    : cardholder_(field.cardholder_),
+    : FormField(),
+      cardholder_(field.cardholder_),
       cardholder_last_(field.cardholder_last_),
       type_(field.type_),
       number_(field.number_),
diff --git a/chrome/browser/autofill/name_field.cc b/chrome/browser/autofill/name_field.cc
index 83f5b16..3510e16 100644
--- a/chrome/browser/autofill/name_field.cc
+++ b/chrome/browser/autofill/name_field.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -152,7 +152,8 @@ FirstLastNameField::FirstLastNameField()
 }
 
 FirstLastNameField::FirstLastNameField(const FirstLastNameField& field)
-    : first_name_(field.first_name_),
+    : NameField(),
+      first_name_(field.first_name_),
       middle_name_(field.middle_name_),
       last_name_(field.last_name_),
       middle_initial_(field.middle_initial_) {
diff --git a/chrome/browser/autofill/phone_number.cc b/chrome/browser/autofill/phone_number.cc
index bdeee11..8c4de77 100644
--- a/chrome/browser/autofill/phone_number.cc
+++ b/chrome/browser/autofill/phone_number.cc
@@ -130,7 +130,8 @@ void PhoneNumber::set_number(const string16& number) {
 }
 
 PhoneNumber::PhoneNumber(const PhoneNumber& phone_number)
-    : country_code_(phone_number.country_code_),
+    : FormGroup(),
+      country_code_(phone_number.country_code_),
       city_code_(phone_number.city_code_),
       number_(phone_number.number_),
       extension_(phone_number.extension_) {