diff options
author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-15 17:21:10 +0000 |
---|---|---|
committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-15 17:21:10 +0000 |
commit | daa8c58ee49795d292312bbf217999c93693919c (patch) | |
tree | 561a327f148d74b0522871f15103e25a27b841f5 /chrome/browser/autofill_manager.h | |
parent | 0b97342d07fd3ef047432b52809d31d10432ee85 (diff) | |
download | chromium_src-daa8c58ee49795d292312bbf217999c93693919c.zip chromium_src-daa8c58ee49795d292312bbf217999c93693919c.tar.gz chromium_src-daa8c58ee49795d292312bbf217999c93693919c.tar.bz2 |
Extract form related classes from the guts of WebFrameImpl.
Instead of having WebFrameImpl generate SearchableFormData, PasswordForm, and AutofillForm classes, allow the embedder (RenderView) to do so.
This is done to help minimize the dependencies WebFrameImpl has on other code, which will make it easier to move WebFrame and WebDataSource into the WebKit API.
Most significant change: Now, RenderView always sets a NavigationState on WebDataSource instances. We used to only do so for browser initiated navigations. This is done so that we can store things like SearchableFormData and friends on the NavigationState.
To facilitate this change, it was necessary to add a way through the WebKit API to refer to a HTMLFormElement. This CL introduces WebForm, which is like a RefPtr<HTMLFormElement>, so you can just copy a WebForm around by value and the right thing happens.
Some of the other changes are about moving more things into the webkit_glue namespace. On hindsight, I probably should have done that as a separate CL.
BUG=10041
TEST=none
R=brettw
Review URL: http://codereview.chromium.org/126083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18395 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autofill_manager.h')
-rw-r--r-- | chrome/browser/autofill_manager.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/chrome/browser/autofill_manager.h b/chrome/browser/autofill_manager.h index 020c2ce..06320fc 100644 --- a/chrome/browser/autofill_manager.h +++ b/chrome/browser/autofill_manager.h @@ -10,7 +10,10 @@ #include "chrome/browser/webdata/web_data_service.h" #include "chrome/common/pref_member.h" +namespace webkit_glue { class AutofillForm; +} + class Profile; class TabContents; @@ -27,7 +30,7 @@ class AutofillManager : public WebDataServiceConsumer { // Called when a form is submitted (i.e. when the user hits the submit button) // to store the form entries in the profile's sql database. - void AutofillFormSubmitted(const AutofillForm& form); + void AutofillFormSubmitted(const webkit_glue::AutofillForm& form); // Starts a query into the database for the values corresponding to name. // OnWebDataServiceRequestDone gets called when the query completes. @@ -47,7 +50,7 @@ class AutofillManager : public WebDataServiceConsumer { static void RegisterUserPrefs(PrefService* prefs); private: - void StoreFormEntriesInWebDatabase(const AutofillForm& form); + void StoreFormEntriesInWebDatabase(const webkit_glue::AutofillForm& form); TabContents* tab_contents_; |