diff options
| author | beng@google.com <beng@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-14 02:31:13 +0000 |
|---|---|---|
| committer | beng@google.com <beng@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-14 02:31:13 +0000 |
| commit | c5b64b34cbd3fe0cabc5f0e086810e4277908b9f (patch) | |
| tree | 40d9764e49c01aba7ffcd9bacb4699bb16b4c5b0 /chrome/browser/automation/automation_provider.cc | |
| parent | 28b2c9f571517b8b5e733d08e8245dc04dd7c7b3 (diff) | |
| download | chromium_src-c5b64b34cbd3fe0cabc5f0e086810e4277908b9f.zip chromium_src-c5b64b34cbd3fe0cabc5f0e086810e4277908b9f.tar.gz chromium_src-c5b64b34cbd3fe0cabc5f0e086810e4277908b9f.tar.bz2 | |
Fix interactive UI tests...
- in the UI tests, SimulateOSClick was taking screen coordinates and the browser automation provider was treating them as client. For a click, screen coordinates seems better and is what most users were sending. This was causing the focus tests to fail since tabs weren't getting clicked on. Not sure why this wasn't affecting non-new-frames!
- a math error in BrowserView2 was leading to incorrect window sizing in constrained window tests.
- new frames mean layout is slightly different, and a constant in the constrained window test needed to be adjusted.
Review URL: http://codereview.chromium.org/2828
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2180 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/automation/automation_provider.cc')
| -rw-r--r-- | chrome/browser/automation/automation_provider.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc index 999ca75..4c1ed49 100644 --- a/chrome/browser/automation/automation_provider.cc +++ b/chrome/browser/automation/automation_provider.cc @@ -1229,8 +1229,6 @@ void AutomationProvider::WindowSimulateClick(const IPC::Message& message, if (window_tracker_->ContainsHandle(handle)) { hwnd = window_tracker_->GetResource(handle); - BOOL r = ::ClientToScreen(hwnd, &click); - DCHECK(r); ui_controls::SendMouseMove(click.x, click.y); ui_controls::MouseButton button = ui_controls::LEFT; |